Why am I getting property undefined in my JavaScript object?

Question

I created a function to generate and return an object:

function TickersObj(tag, array, boolLots, boolOptions, boolDisplay) {
    tag         = tag         || {};
    array       = array       || [];
    boolLots    = boolLots    || false;
    boolOptions = boolOptions || false;
    boolDisplay = boolDisplay || true;

    console.log('tag = ', tag);
    console.log('array = ', array);
    console.log('boolLots = ', boolLots);
    console.log('boolOptions = ', boolOptions);
    console.log('boolDisplay = ', boolDisplay);

    this.assoTikArray     = array;
    this.lotsOfTags       = boolLots;
    this.tagOptions       = boolOptions;
    this.tagsHoverDisplay = boolDisplay;
    return this;
}

Later down in my code I pass in the values like so:

switch(type) {
    case 'tagsPanel':
        tag.tickers  = data.data.ticker_tag.tickers;
        var tickersObj = TickersObj(tag, tag.tickers, tag.lotsOfTags, true, true);
        return tickersObj;
        break;
        ....

However once it gets to this line this.assoTikArray = array; I get the error Cannot set property assoTikArray of undefined

Thoughts on what I'm doing wrong?

Alternatively, you could just return an object with those keys, rather than calling it as a constructor. — Evan Davis
– Evan Davis, Commented Aug 5, 2015 at 19:18
True.. but I have 3 different cases, figured a function to make it would work better in that case? — Leon Gaban
– Leon Gaban, Commented Aug 5, 2015 at 19:20
No, you keep the function, but rather than assigning properties to this (making it a constructor) you just return an object, return { assoTikArray: array, ...} (making it a factory.) — Evan Davis
– Evan Davis, Commented Aug 5, 2015 at 19:35

Community · Accepted Answer · 2017-05-23 11:57:57Z

8

You are simply calling the function without context (i.e. TickersObj() and not something.TickersObj()), so the value of this inside it is either the default object (window in a browser) or undefined (in strict mode). Presumably you are in strict mode.

To create a new instance of a function you have to call it with the new keyword.

var tickersObj = new TickersObj(tag, tag.tickers, tag.lotsOfTags, true, true);

edited May 23, 2017 at 11:57

CommunityBot

11 silver badge

answered Aug 5, 2015 at 19:14

Quentin

948k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Why am I getting property undefined in my JavaScript object?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related