Angular HTTP promise returns empty

Question

I have a factory with a HTTP GET request and I used promises as the documentations says I should, using $q service, but it is returning an empty promise:

App.factory('dataFactory', ['$rootScope','$http','$q', function($rootScope,$http,$q) {

  // Objeto del factory 
  var fac = {};

  // Funcion que obtiene un mensaje completo
  fac.obtenerListaMensajes = function(compania,userhid){

    var deferred = $q.defer(); 

    $http({ 
            method: 'GET', 
            url: urlListaMensajes, 
            params: {company:compania,userhid:userhid}
          }).
      then(function(response) {

        deferred.resolve(response.data.messages);

        console.log(JSON.stringify(deferred.promise));

        }, function(error) {
          deferred.reject(error);
    });

    return deferred.promise;
  };

  return fac;

}]);

The controller:

App.controller('MailFolderController', ['$scope','$rootScope','dataFactory', '$stateParams', function($scope, $rootScope, dataFactory, $stateParams) {

  // Variables de PRUEBA
  var user_prueba = 'MTQzMjU4NjUyNDcxMzczNzQwNjE3MTg1ODMxMDY5OTQ2';
  var company_prueba = 'development';

  $scope.mails = dataFactory.obtenerListaMensajes(company_prueba,user_prueba);
}]);

The final value in $scope.mails is:

{"$$state":{"status":0}}

I know for a fact that the HTTP request works properly thanks to the console.log inside it.

What am I doing wrong? I could use $rootScope to return the value, it works, but it would be a bad programming strategy.

dfsq · Accepted Answer · 2015-08-11 20:06:23Z

5

Proper way to use service in controller would be:

dataFactory.obtenerListaMensajes(company_prueba, user_prueba).then(function(data) {
    $scope.mails = data;
});

Also you can improve service by getting rid of redundant dummy deferred object, you don't need it since $http already returns promise:

App.factory('dataFactory', ['$rootScope', '$http', '$q', function ($rootScope, $http, $q) {

    // Objeto del factory 
    var fac = {};

    // Funcion que obtiene un mensaje completo
    fac.obtenerListaMensajes = function (compania, userhid) {
        return $http({
            method: 'GET',
            url: urlListaMensajes,
            params: {
                company: compania,
                userhid: userhid
            }
        }).
        then(function (response) {
            return response.data.messages;
        });
    };

    return fac;

}]);

answered Aug 11, 2015 at 20:06

dfsq

193k26 gold badges244 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

David Prieto Over a year ago

So it was just ignorance from my part. Thank you.

Collectives™ on Stack Overflow

Angular HTTP promise returns empty

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related