PHP String returns with HTML

Question

I want to return HTML string as follows from my controller.

$returnValue = "<a onclick='demosuccess(".
    chunk_split( base64_encode( $details['clientid'] ) ).
    ",".chunk_split( base64_encode( $details['email'] ) ).
    ",1)' >$this->lang->line('link_sendactivation')</a>";

But,it getting error.I tried it by different combinations of single and double quotes .Please help me to call demosuccess function using above html string....Thanks

What is the error you're getting ?

Boris Delormas
– Boris Delormas

2010-07-12 09:24:26 +00:00
Commented Jul 12, 2010 at 9:24 — Boris Delormas
– Boris Delormas, Commented Jul 12, 2010 at 9:24
(tipp) sprintf returns a formatted string

Gordon
– Gordon

2010-07-12 09:33:23 +00:00
Commented Jul 12, 2010 at 9:33 — Gordon
– Gordon, Commented Jul 12, 2010 at 9:33
Why do you split the Base-64 value in chunks?

Gumbo
– Gumbo

2010-07-13 08:13:01 +00:00
Commented Jul 13, 2010 at 8:13 — Gumbo
– Gumbo, Commented Jul 13, 2010 at 8:13

antpaw · Accepted Answer · 2010-07-12 09:28:36Z

3

$client_id = chunk_split(base64_encode($details['clientid']));
$email = chunk_split(base64_encode($details['email']));    
$lang_line = $this->lang->line('link_sendactivation');
$returnValue = "<a onclick='demosuccess($client_id, \"$email\", 1)'>$lang_line</a>";

answered Jul 12, 2010 at 9:28

antpaw

16.1k11 gold badges63 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Boris Delormas · Accepted Answer · 2010-07-12 09:25:37Z

1

$returnValue = "<a onclick=\"javascript:demosuccess(".chunk_split(base64_encode($details['clientid'])).",".chunk_split(base64_encode($details['email'])).",1);\">".$this->lang->line('link_sendactivation')."</a>";

answered Jul 12, 2010 at 9:25

Boris Delormas

2,5391 gold badge20 silver badges27 bronze badges

Comments

Sadat · Accepted Answer · 2010-07-12 09:25:57Z

1

$returnValue = "<a onclick='demosuccess(".chunk_split(base64_encode($details['clientid'])).",".chunk_split(base64_encode($details['email'])).",1)' >".$this->lang->line('link_sendactivation')."</a>";

answered Jul 12, 2010 at 9:25

Sadat

3,4812 gold badges33 silver badges45 bronze badges

Comments

Moak · Accepted Answer · 2010-07-13 09:55:30Z

1

Try breaking things up a bit,

$id = chunk_split(base64_encode($details['clientid']));
$email = chunk_split(base64_encode($details['email']));
$thirdthing = $this->lang->line('link_sendactivation');
$returnValue = '<a onclick="demosuccess(\''.$id.'\',\''.$email.'\',\'1\')" >'.$thirdthing.'</a>';

edited Jul 13, 2010 at 9:55

answered Jul 12, 2010 at 9:26

Moak

12.9k27 gold badges117 silver badges168 bronze badges

3 Comments

Aadi Over a year ago

Thank you..it is not working which is passing the argument something like as follows javascript:demosuccess(MQ== ,YWpqZGtkQHJpbi5jb20= ,1).here we need to put all with in quotes like javascript:"demosuccess('MQ== ','YWpqZGtkQHJpbi5jb20=' ,'1')".

Moak Over a year ago

changed, escape the quotes like this \'

Gumbo Over a year ago

There is no need to use the javascript label if you don’t want to use it with break or continue. The onclick value is already interpreted as script code.

Gumbo · Accepted Answer · 2010-07-13 08:08:45Z

The problem here is that you cannot use a a method call like your $this->lang->line('link_sendactivation') inside a string declaration.

You either need to get the return value of that method in advance and store it in a temporary variable:

$tmp = $this->lang->line('link_sendactivation');
$returnValue = "<a onclick='demosuccess(".chunk_split(base64_encode($details['clientid'])).",".chunk_split(base64_encode($details['email'])).",1)' >$tmp</a>";

Or you concatenate that return value with the other parts (just like you did it with chunk_split):

$returnValue = "<a onclick='demosuccess(".chunk_split(base64_encode($details['clientid'])).",".chunk_split(base64_encode($details['email'])).",1)' >".$this->lang->line('link_sendactivation')."</a>";

Or you use sprintf like Gordon suggested:

$returnValue = sprintf("<a onclick='demosuccess(%s,%s,1)' >%s</a>",
    chunk_split(base64_encode($details['clientid'])),
    chunk_split(base64_encode($details['email'])),
    $this->lang->line('link_sendactivation'));

Futhermore you probably forgot to quote the chunked Base-64 values in JavaScript. You can use json_encode to do that:

$returnValue = sprintf("<a onclick='demosuccess(%s,%s,1)' >%s</a>",
    json_encode(chunk_split(base64_encode($details['clientid']))),
    json_encode(chunk_split(base64_encode($details['email']))),
    $this->lang->line('link_sendactivation'));

Collectives™ on Stack Overflow

PHP String returns with HTML

5 Answers 5

Comments

Comments

Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related