javascript: remove values from an array that are in a second array

Question

Using pure javascript, starting with an array, I would like to return and array by removing values that match any value in a second array.

I have solved this problem, but I believe with more code than is really necessary.

I am hoping for a more concise or elegant solution using only javascript.

function removeValues(arr){
    array = arguments[0];
    args = Array.prototype.slice.call(arguments);
    len = arguments.length;
        filtered = array.filter(function(n){
            x = true;
            for (var i = 1; i < len; i++) {
                if (n == args[i]) { x = false; }
            }
            return x;
        });
    return filtered;
}

removeValues([1,2,3,1,2,3],2,3);

Should use a function that removes values from the first argument (an array) using values in one or more additional arguments.

Its not only this, but when u are making bigger app, framework is saving lot of time — Jaroslav Štreit
– Jaroslav Štreit, Commented Sep 2, 2015 at 11:39
agreed. This is a JS algorithm problem, so not about saving time but practicing programming. I will read the docs on grep though, thanks for that it was helpful. — dtburgess
– dtburgess, Commented Sep 2, 2015 at 11:40

Community · Accepted Answer · 2017-05-23 11:52:12Z

3

When you're working with the filter function is not necessary to use loops because you're already in a loop. After converting the arguments into an array with [].slice.call(arguments), you could use indexOf that is responsible for returning the position of a value in an array, if a value is not exists, this returns -1, so we will take all the results that are -1

Your code could be reduced as well:

function removeValues(arr){
  return arr.filter(function(val){
    return [].slice.call(removeValues.arguments).slice(1).indexOf(val) === -1
  })
}

console.log(removeValues([1,2,3,1,2,3],2,3))

ES6 Method: Using Rest parameters and Arrow Functions

var removeValues = (arr, ...values) => arr.filter(val => values.indexOf(val) === -1)

edited May 23, 2017 at 11:52

CommunityBot

11 silver badge

answered Sep 2, 2015 at 11:42

Walter Chapilliquen - wZVanG

12.1k8 gold badges44 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

dtburgess Over a year ago

Could you explain a bit more in the answer how this works?

Walter Chapilliquen - wZVanG Over a year ago

If you mean to ES6 method, you could go to 2 typed links, is where is explained in detail about Rest parameters and Arrow Functions, the operation is the same

Reinstate Monica Cellio · Accepted Answer · 2015-09-02 11:55:57Z

3

Try this instead...

function removeValues(){
    var args = Array.prototype.slice.call(arguments).slice(1);
    return arguments[0].filter(function(value) {
        return args.indexOf(value) === -1;
    });
}

removeValues([1, 2, 3, 1, 2, 3], 2, 3);

It does the exact same thing, but tidies it slightly.

edited Sep 2, 2015 at 11:55

answered Sep 2, 2015 at 11:41

Reinstate Monica Cellio

26.2k6 gold badges54 silver badges67 bronze badges

1 Comment

Walter Chapilliquen - wZVanG Over a year ago

Array.prototype.slice.call(arguments), also take the first argument, to be exact should be: Array.prototype.slice.call(arguments).slice(1). args = in strict mode it will fail, it should be declared as local variable var args =

DDan · Accepted Answer · 2015-09-02 11:41:35Z

1

Try like this:

var array1 = [ 1, 2, 3, 4, 5 ];
var array2 = [ 2, 3 ];

var result = array1.filter( function ( elem ) {
    return array2.indexOf( elem ) === -1;
});

See example: Running code

answered Sep 2, 2015 at 11:41

DDan

8,3566 gold badges38 silver badges65 bronze badges

Collectives™ on Stack Overflow

javascript: remove values from an array that are in a second array

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related