Symfony2: Using renderView method in new Controller

Question

I got two Controllers:

class FirstController extends Controller
{
    /**
     * @Route("/first")
     */
    public function indexAction()
    {
        $second = new SecondController();
        $second->doit();
    }
}


class SecondController extends Controller
{
    public function doit()
    {
        $render = $this->renderView('::base.html.twig');
        //write $render to disk
    }
}

Instead of 'done' being written to my screen, I got error:

What am I doing wrong?

greg0ire · Accepted Answer · 2015-10-03 22:11:59Z

2

You are not supposed to instantiate controllers yourself. The framework is supposed to do that for you. If you are in controller1, and want controller2 to actually handle the request, which could use some explanation on your part, you need to forward to it, like this : $this->forward('MyBundle:MyController:myaction)

Also, you should maybe have your doit method in a service. Controllers are supposed to stay skinny, and care only about HTTP:

they receive the request
they call a service based on the request, this service should know nothing about HTTP, and be callable from a command as well as from a controller
they return a response based on what the service answers.

edited Oct 3, 2015 at 22:11

answered Oct 3, 2015 at 21:51

greg0ire

23.3k17 gold badges76 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Frank B Over a year ago

and you should use the Action prefix e.g. indexAction()

greg0ire Over a year ago

I am not sure the thing he calls even is an action, that's also why I'm suggesting to use a service.

Collectives™ on Stack Overflow

Symfony2: Using renderView method in new Controller

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related