javascript text doesn't display

Question

I was making a simple program "Find the Largest Number". The problem is, I can't display the output of my answer. Is there anything wrong on my code? Thanks

<html>
<head>
<title> Short Lab Activity 1 </title>

<style>
#compute{
text-align: center;
}
</style>
</head>

<body>
<div id="compute">
Input 1st Number: <input type="integer" id="num1" size="20"/> </br></br>
Input 2nd Number: <input type="integer" id="num2" size="20"/> </br></br>
Answer: <input type="integer" id="answer" size="20"/>
</div>
<center><input type="button" id="find" value="Find the Largest" onClick()="find()"/></center>

<script type="text/javascript">
     function find() {
     var numb1 = document.getElementById("num1").value;
     var numb2 = document.getElementById("num2").value;
     var answer;

     if(numb1 > numb2)
        document.getElementById("answer").value = numb1;
     if(numb2 > numb1)
        document.getElementById("answer").value = numb2;
         }

</script>
</body>
</html>

This will not help solve your problem but the type='integer' is invalid (the browser will convert this to text). A list of correct types, and their use, can be found at: html5doctor.com/html5-forms-input-types — user2417483
– user2417483, Commented Oct 10, 2015 at 2:16

Jason · Accepted Answer · 2015-10-10 13:05:21Z

1

Change onClick()="find()" to onClick="find()"

edited Oct 10, 2015 at 13:05

answered Oct 10, 2015 at 2:02

Jason

2,7333 gold badges16 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Elipzer · Accepted Answer · 2015-10-10 02:12:03Z

0

Your error is here:

<input type="button" id="find" value="Find the Largest" onClick()="find()"/>

Change it to:

<input type="button" id="find" value="Find the Largest" onClick="find()"/>

You do not need the parenthesis ()

answered Oct 10, 2015 at 2:12

Elipzer

9117 silver badges22 bronze badges

Comments

frosty · Accepted Answer · 2015-10-10 02:47:14Z

0

The obvious mistake is that instead of onClick() = "find()" it should be onclick = "find()". .

answered Oct 10, 2015 at 2:47

frosty

2,67910 gold badges42 silver badges86 bronze badges

Comments

thedeliciousmuffin · Accepted Answer · 2015-10-10 03:05:53Z

0

I would not recommend using onclick in the html. Instead you could use addEventListener.

As for modifications to your function, if statement could be written like this,

if (numb1 > numb2) {
    document.getElementById("answer").value = numb1;
} else if (numb2 > numb1) {
    document.getElementById("answer").value = numb2;
}

Now after your function, you can add the event listener like this,

var el = document.getElementById("find");
el.addEventListener("find", find, false);

You can learn more about the addEventListener function here.

answered Oct 10, 2015 at 3:05

thedeliciousmuffin

8141 gold badge11 silver badges22 bronze badges

Collectives™ on Stack Overflow

javascript text doesn't display

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related