Function doesn't validate input

Question

I can't figure out why my code doesn't validate my input value. I get "not working" for all scenarios.

This is my code:

<body>


<input type="text" placeholder="User Name" id="id_inputuser"/>
<label>Enter User Name</label><br>
<input type="text" placeholder="Password"id="id_inputpass"/>
<label>Enter Password</label><br><br>

<button onClick="verify()">Enter</button>
</body>

Javascript:

var user = document.querySelector('#id_inputuser').value;

function verify()

{if (user == "david")
{alert("working");}

else{alert("not working")};
}

Can someone help?

Thanks a lot!

Can you list your scenarios? If the input is not "david" it will fail... what is the desired behavior? — ZachB
– ZachB, Commented Dec 2, 2015 at 19:22

nanocv · Accepted Answer · 2015-12-02 19:26:54Z

2

You have to read the input value inside the function.

function verify(){
    var user = document.querySelector('#id_inputuser').value;
    if (user == "david"){
        alert("working");
    }
    else{
        alert("not working");
   }
}

If you let that sentence out of the function, it is executed when the page is loaded, and in that moment, the input has not value.

answered Dec 2, 2015 at 19:26

nanocv

2,2292 gold badges16 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user3185970 Over a year ago

Whenn i put the var inside the function, i get an error: Unexpected token var. Do you know why?

nanocv Over a year ago

Yes, you have a typo with some parenthesis or braces. Check it all. In you original code, for example, in the else sentence, you had the alert semicolon out of the closing brace.

nanocv Over a year ago

If you don't have copied my code but used yours, maybe you have written that sentence before the opening brace of the function (between "verify()" and "{if"). That would cause the error.

user3185970 Over a year ago

You were right, it was a brackets mistake. Thanks a lot!

wiredolphin · Accepted Answer · 2015-12-02 19:29:34Z

0

Your call to querySelector gets the value when the field is empty, that means when the DOM is ready, and not after you've changed the input field. You need to catch the value when you call the function you've provided.

answered Dec 2, 2015 at 19:29

wiredolphin

1,6511 gold badge20 silver badges27 bronze badges

Collectives™ on Stack Overflow

Function doesn't validate input

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related