Javascript function only running on the first call

Question

I have a function opening a new window, attached to a button:

<button onclick="newWin()">New Window</button>

This works fine but just the first time it is clicked. Following times, even when the opened window has been closed, I have this error:

TypeError: newWin is not a function

This is the JS function:

function newWin() {
       newWindow= window.open('pan/newWin.html', 'Nueva ventana', 'toolbar=yes,location=no,resizable=no,width=600,height=820');}

That doesn't make any sense. What you've posted should work. There is obviously more to this problem than in your example. — Liam
– Liam, Commented Dec 14, 2015 at 17:03
are you sure that inside newWindow=... and not newWin=...? can you provide jsfiddle? — Grundy
– Grundy, Commented Dec 14, 2015 at 17:03
That was it. Certainly it is newWin, same name as function. Thank you — Biomehanika
– Biomehanika, Commented Dec 14, 2015 at 17:04
Please don’t correct your code in the question, as it invalidates the answers that solve your issue. — Sebastian Simon
– Sebastian Simon, Commented Dec 14, 2015 at 17:09

Grundy · Accepted Answer · 2015-12-14 17:10:39Z

1

You have two mistake:

In your case you just redefine global property newWin from function to object.

for solving you can rename it, or just use var keyword: var newWin = window.open(...)

answered Dec 14, 2015 at 17:10

Grundy

13.4k3 gold badges39 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dnyanesh · Accepted Answer · 2015-12-14 17:05:17Z

1

Your are assigning some object to function variable.

First time on page load newWin() will be loaded as function. After execution of function you are assigning some value to it .

Hence it is resulting in to error.

answered Dec 14, 2015 at 17:05

Dnyanesh

2,3633 gold badges20 silver badges17 bronze badges