passing a paramter into a loop perl using a subroutine

Question

i want to read a file1 that containfor every word a numeric reprsentation, for example:

clinton 279
capital 553
fond|fonds 1410

I read a second file, every time i find a number i replace it with the corresponding word. above an example of second file

279 695 696 152 - 574
553 95 74 96 - 444
1410 74 95 96 - 447

The problem in my code is that it execute the subroutine only one time. and it only show:

279 clinton

normally in this example it should show 3 words, when i add print $b; in the subrtoutine it show the different numbers.

#!/usr/bin/perl
use stricrt;
use warnings;
use autodie;

my @a,my $i,my $k;
my $j;

my $fich_in = "C:\\charm\\ats\\4.con";
my $fich_nom = "C:\\charm\\ats\\ats_dict.txt";


open(FICH1, "<$fich_in")|| die "Problème d'ouverture : $!";
open my $fh, '<', $fich_nom;

#here i put the file into a table

while (<FICH1>) {
my $ligne=$_;
chomp $ligne; 


my @numb=split(/-/,$ligne);
my $b=$numb[0];
    $k=$#uniq+1;
    print   "$b\n";
     my_handle($fh,$b);
}

sub my_handle {
    my ($handle,$b) = @_;
    my $content = '';
#print "$b\n";

    ## or line wise
    while (my $line = <$handle>){
    my @liste2=split(/\s/,$line);
if($liste2[1]==$b){
        $i=$liste2[0];
            print "$b $i";}
        }
return $i;
}


    close $fh;
    close(FIC1);

It looks like you have assembled this program by copy/pasting from various sources. Do you understand what's going on in there? Please edit the question and indent your code properly. Also, please always use strict and use warnings in code that you post on SO (and also when you try to run it on your machine, obviously). — simbabque
– simbabque, Commented Jan 8, 2016 at 12:48
this is my code and the problem is it when i pass the paramter $b in the subroutine my_handle($fh,$b);, it only work one time so the subroutine show one word and not all the word that correspond to the paramter $b — Chedi Bechikh
– Chedi Bechikh, Commented Jan 8, 2016 at 12:55
Here's why I think you did not completely write this: you don't have strict or warnings, but you have autodie. Still, you have die on one of your opens. You are using a lexical filehandle with 3-argument-open for one file, and a glob and 2-arg-open for the other, and one close has parens while the other does not. I think you added some of the glue in between yourself, because you have @a[$i], which strict would have complained about as the sigil is wrong. It should be $a[$i] because what is inside of the array @a in position $i is scalar, not an array. ... — simbabque
– simbabque, Commented Jan 8, 2016 at 13:01
... Also $b is reserved and should not be used as it is intended for use inside of a sort block. However, we can try to solve your question. But first, please indent it properly. You can edit the question. Then explain how it is supposed to work, as this code is not doing what you describe in the question. Also, please add at least one more line for the lookup file, and an example of the second input file. — simbabque
– simbabque, Commented Jan 8, 2016 at 13:03

choroba · Accepted Answer · 2016-01-08 14:29:31Z

3

The common approach to similar problems is to hash the "dictionary" first, than iterate over the second file and search for replacements in the hash table:

#!/usr/bin/perl
use warnings;
use strict;

my $fich_in = '4.con';
my $fich_nom = 'ats_dict.txt';

open my $F1, '<', $fich_in  or die "Problème d'ouverture $fich_in : $!";
open my $F2, '<', $fich_nom or die "Problème d'ouverture $fich_nom : $!";;

my %to_word;
while (<$F1>) {
    my ($word, $code) = split;
    $to_word{$code} = $word;
}

while (<$F2>) {
    my ($number_string, $final_num) = split / - /;
    my @words = split ' ', $number_string;
    $words[0] = $to_word{ $words[0] } || $words[0];
    print "@words - $final_num";
}

answered Jan 8, 2016 at 14:29

choroba

245k27 gold badges221 silver badges304 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Chedi Bechikh Over a year ago

this code work well, just reverse F1 and F2, and the code has warning use of unintialized value $word[0] in hash element

choroba Over a year ago

@ChediBechikh: It's just a warning. Probably coming from empty lines in the file?

Chedi Bechikh Over a year ago

you are right, can you epain to me why i find problem with my code, only the first word is terated

choroba Over a year ago

@ChediBechikh: I don't understand your code. Maybe you exhaust $fh in the first run and there's nothing else to read from the file?

Collectives™ on Stack Overflow

passing a paramter into a loop perl using a subroutine

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related