Replace String In Object Property Value After Looping Array Javascript

Question

I'm needing to replace a character in an object's property value. I'm looping over the array of objects (outputting to console) and retrieving the FeatureUrl property.

I have data coming back from the Svc for that property in the following form:

index.html#/blah

I'm needing to replace the '#' with '#/app' so that my new url comes back in the following form:

index.html#/app/blah

I'm not sure if .replace is the right method to use here, but it is what I have seen suggested. Can someone point me in the right direction?

var localFeatureDetails = function() {
    $scope.user = userService.GetUserInformation();
    $scope.featureDetails = $scope.user.Features;

  var featureUrlRewrite = function () {
    var index;
    var urlCount;
    for (index = 0; index < $scope.featureDetails.length; index++) {
      urlCount = $scope.featureDetails[index];
      urlCount.FeatureUrl.replace("#","#/app");
      console.log(urlCount);
    }
  };

  featureUrlRewrite();

};
localFeatureDetails();

Does this work? Are you asking for confirmation? If that's the case I recommend using codereview.stackexchange.com — Joe Essey
– Joe Essey, Commented Mar 15, 2016 at 14:52
if the code works the way you intend it to, then it may be a good fit on CR. Does this code work? — Malachi
– Malachi, Commented Mar 15, 2016 at 14:53
Replace at takes the location in the string, the OP is looking for a specific character in the string and replacing it with a set of characters. replaceAt is not the right tool here. the location in the string array may change based on the page — Malachi
– Malachi, Commented Mar 15, 2016 at 14:59
+1, this is not a duplicate of the suggested question. replaceAt would not work here, OP appears to want a mutable version of replace. Unfortunately, strings are immutable so no such method exists. The suggested answer seems to do what you would want. — Dan
– Dan, Commented Mar 15, 2016 at 15:04
The code loops and returns the index(s) of the array and the property that I need, but the .replace() method is not replacing the characters that I need it to. It is coming back unchanged. — billy_comic
– billy_comic, Commented Mar 15, 2016 at 15:23

dchayka · Accepted Answer · 2016-03-15 15:01:38Z

1

I did not test your code but based on how .replace() works you have to assign the value to your object property again by overriding it otherwise you're not saving the value.

Assuming everything else is correct, try this: $scope.featureDetails[index].FeatureUrl = urlCount.FeatureUrl.replace("#","#/app");

Reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace

answered Mar 15, 2016 at 15:01

dchayka

1,31213 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

billy_comic Over a year ago

@dc hayka this worked perfectly. I altered just a tad, but great solution.

dchayka Over a year ago

@billy_comic awesome, glad to help :)

Malachi · Accepted Answer · 2016-03-15 15:28:56Z

1

I think that you might want something more like this

$scope.featureDetails.map(detail => angular.merge({}, detail, 
    { FeatureUrl: detail.replace('#', '#/app') }))

instead of the bulky for loop.

we take every detail object out of the featureDetails array, access the FeatureUrl property and replace the # with #/app

.merge(destination, ...sources) merges sources into destination, left-to-right, overwriting properties as it goes.

so angular.merge({}, {foo: 5, bar: 3}, {foo: 7}) would return { foo: 7, bar: 3 }

Removed the console.log() but you can always

console.log($scope.featureDetails);

and then look at the object that is returned in the inspector.

edited Mar 15, 2016 at 15:28

answered Mar 15, 2016 at 15:20

Malachi

3,2514 gold badges31 silver badges49 bronze badges

1 Comment

billy_comic Over a year ago

I'm going to try this as anytime I can avoid a loop, i'm down. Thx for the suggestion.

Collectives™ on Stack Overflow

Replace String In Object Property Value After Looping Array Javascript

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related