jQuery function string

Question

This isn't working:

function checkIt(String rep) {
         if (counter[$(rep).val()] == undefined) {
         count++;
         result = Math.round((count * 100 )/howMany);
         $('.percent').text(result);
         $('#perc_in').animate({'width': result+'%'}, 500);
         counter[$(this).val()] = 1;
         $('#counter').text(result);
         }
}

Like, at all... <_< I mean I think I am doing the function wrong.

Then inside the case statement I have this:

checkIt($(this).val());

Yi Jiang · Accepted Answer · 2010-09-12 00:53:35Z

3

Javascript is weak typed, so what in the world is this?

function checkIt(String rep) {

Just change it to

function checkIt(rep) {

It's also a bit odd that you are try to create a new jQuery object from the value of another form element. And this line:

if (counter[$(rep).val()] == undefined) {

This may be a little dangerous if you're just checking for the non-existence of an array element, since $(rep).val() could also be undefined depending on the situation.

edited Sep 12, 2010 at 0:53

answered Sep 12, 2010 at 0:43

Yi Jiang

50.2k16 gold badges139 silver badges137 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

karim79 Over a year ago

Also, it is unclear where count is defined, and what it is used for (if at all).

Yi Jiang Over a year ago

@karim Well, let's assume that all variables are declared. If not we could just as easily say that jQuery isn't properly load ;). As for uses erm... some sort of global count on how many times this function has been called?

karim79 Over a year ago

@Yi Jiang - good point. Would be good to know, as it looks downright confusing :) I voted you up btw, that wasn't a 'gripe' but an innocuous (and I hoped useful) comment :)

test Over a year ago

OK that seems to work for only two of cases.... and I get undefnied when i do $(rep).val()...

Yi Jiang Over a year ago

@Dan Two possible reasons: 1. rep isn't a valid selector, so jQuery's returning undefined. 2. The element selected by $(rep) doesn't have a value attribute. Not that I didn't warn you on that in the answer...

|

Collectives™ on Stack Overflow

jQuery function string

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related