Call PowerShell script from VBScript but windows close

Question

This VBScript runs a few PowerShell scripts. I put the invocation of notepad.exe there to make sure it ran as an admin.

My PowerShell scripts open consoles but then they close immediately.
I would like to have them stay open.

What is wrong?

Here is my VBScript:

RunAsAdmin()

Set shell = WScript.CreateObject("WScript.shell")
shell.Run("powershell.exe -noexit -executionpolicy bypass -file .\Source\RemoveWindows10Apps-2.0.ps1"), 1 , True

Set shell = WScript.CreateObject("WScript.shell")
shell.Run("powershell.exe -noexit -executionpolicy bypass -file .\Source\ChangeWin10StartLayout.ps1"), 1 , True

Set shell = WScript.CreateObject("WScript.shell")
shell.Run("powershell.exe -noexit -executionpolicy bypass -file .\Source\NewFolder.ps1"), 1 , True

Set shell = WScript.CreateObject("WScript.shell")
shell.Run("notepad.exe"), 1 , True


Function RunAsAdmin()
  Dim objAPP
  If WScript.Arguments.length = 0 Then
    Set objAPP = CreateObject("Shell.Application")
    objAPP.ShellExecute "wscript.exe", """" & _
    WScript.ScriptFullName & """" & " RunAsAdministrator",,"runas", 1
    WScript.Quit
  End If
End Function

Possible duplicate of How to keep the shell window open after running a PowerShell script? — user4317867
– user4317867, Commented Jul 16, 2016 at 16:38
It has something to do with the RunAsAdmin function because when I take it out my windows stay open but they don't run as an admin. — itsbaxagain
– itsbaxagain, Commented Jul 16, 2016 at 17:43
Does the answer have to be in VBScript? Here is some powershell that elevates within the script — user4317867
– user4317867, Commented Jul 16, 2016 at 17:55

DAXaholic · Accepted Answer · 2016-07-16 18:16:16Z

2

I guess it is because you use relative paths so when your script will call itself as admin your current directory will change to ...\WINDOWS\system32.

Try it with building absolute paths and pass them to PowerShell like so

RunAsAdmin()

strScriptPath = Wscript.ScriptFullName
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFile = objFSO.GetFile(strScriptPath )
strScriptFolder = objFSO.GetParentFolderName(objFile) 

Set shell = WScript.CreateObject("WScript.shell")
shell.Run("powershell.exe -noexit -executionpolicy bypass -file " & strScriptFolder & "\Source\RemoveWindows10Apps-2.0.ps1"), 1 , True

...

answered Jul 16, 2016 at 18:16

DAXaholic

35.9k6 gold badges84 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

itsbaxagain Over a year ago

Thank you that fixed it.

Collectives™ on Stack Overflow

Call PowerShell script from VBScript but windows close

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related