JavaScript variable replace issue

Question

I want to replace some strings and variables but I don`t know how to make it - my code is below:

var text = "I was born in $city in country $country "

var city = "New YORK"
var country = "USA"

var regex_variable = /\$\s*(.*?)\s/g;
var variable =[];

while (c = regex_variable.exec(text)) {
  variable.push(c[1]);
}

for (n=0;n<variable.length;n++){
  text = text.replace(regex_variable, "kat");
}

console.log(text)

Output from this script is:

I was born in katin country kat

But the point is to replace the kat with the strings from variable city and country. Please note that in the var text some strings has got $ character as a prefix - this strings I want to take from the variables (strings in the text will be the same as a names of variables but with prefix $).

The correct output should be:

I was born in New YORK in country USA

Anyone could help me with it?

You may want to look at JS template literals. var city = 'New York', country = 'USA', text = `I was born in ${city} in country ${country}`; — Rob M.
– Rob M., Commented Sep 1, 2016 at 16:22
the point is that I need to use the $city becase this is just an example - I will received this string from the file with variables like $city — artielegancko
– artielegancko, Commented Sep 1, 2016 at 16:23

Huntro · Accepted Answer · 2016-09-01 16:22:56Z

2

You can just do it like this:

var text = "I was born in $city in country $country ";

var city = "New YORK";
var country = "USA";

text = text.replace("$city", city);
text = text.replace("$country", country);

console.log(text)

answered Sep 1, 2016 at 16:22

Huntro

3221 gold badge3 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

artielegancko Over a year ago

It`s a simples way - you are right :D but problem will be when I will have got more than 100 of this variables - to make a replace for each variable :)

Huntro Over a year ago

Do you know the order of the variables, for example that $city comes first and $country is the secound and so on?

score 1 · Accepted Answer · 2016-09-01 17:32:28Z

1

What you're trying to build is a little "templating" system. If you search for that, you will find lots of things.

Here's a real simple example:

var city = "New YORK";
var country = "USA";
var interpolations = {city, country};
var text = "I was born in $city in country $country";

var newString = text.replace(/\$(\w+)/g, (match, val) => interpolations[val]);

console.log(newString);

edited Sep 1, 2016 at 17:32

answered Sep 1, 2016 at 17:24

user663031

1 Comment

artielegancko Over a year ago

Thank you - this what I was looking for ;)

CoverFire · Accepted Answer · 2016-09-01 16:43:35Z

0

var text = "I was born in $city in country $country "

var city = "New YORK"
var country = "USA"

var replaceArray = [city,country]; //create an array with your variables

var regex_variable = /\$\s*(.*?)\s/g;
var variable =[];

while (c = regex_variable.exec(text)) {
   variable.push(c[1]);
}

for (n=0;n<variable.length;n++){
  text = text.replace("$"+variable[n], replaceArray[n]);
}

console.log(text);

If you know the order of the variables you want to replace, this could be your solution.

answered Sep 1, 2016 at 16:43

CoverFire

12 bronze badges

Comments

SUNITHA K · Accepted Answer · 2016-09-01 18:08:14Z

0

var city = "NEW YORK"

var country = "USA"

var text = "I was born in city in country "

var res = text.replace(/city/gi, city);

var res1 = res.replace(/country/gi, country);

document.write(res1);

answered Sep 1, 2016 at 18:08

SUNITHA K

1481 silver badge3 bronze badges

1 Comment

user663031 Over a year ago

This is a fine solution, but it's not scalable to many variable names.

Collectives™ on Stack Overflow

JavaScript variable replace issue

4 Answers 4

2 Comments

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related