Laravel save() - inserting the data instead update

Question

Want to updating the data using laravel. I make a function inside the model and using that method inside the controller but when calling the method its inserting the data with new id.function as following .

public function edit_client($req,$id) { 
    $client = new client(); 
    $client->find($id); 
    $client->name = $req->name; 
    $client->address = $req->address; 
    $client->email = $req->email; 
    $client->phone = $req->phone; 
    $client->gender = $req->gender; 
    $client->department = $req->department; 
    $client->update();}

Yes, because of $client = new client();.. remove or comment this line and try again. — S.I.
– S.I., Commented Nov 14, 2016 at 12:41
with $client->update(); no changes and with $client->save(); inserting new record — Alfiza malek
– Alfiza malek, Commented Nov 14, 2016 at 12:44

Alexey Mezenin · Accepted Answer · 2016-11-14 12:50:42Z

10

You can do this instead:

public function edit_client($req,$id) { 
    $client = Client::find($id); 
    $client->name = $req->name; 
    $client->address = $req->address; 
    $client->email = $req->email; 
    $client->phone = $req->phone; 
    $client->gender = $req->gender; 
    $client->department = $req->department; 
    $client->save();
}

Or use update() method:

public function edit_client($req,$id) { 
    $client = Client::where('id', $id)->update([
        'name' = $req->name,
        'address' = $req->address,
        'email' = $req->email,
        'phone' = $req->phone,
        'gender' = $req->gender,
        'department' = $req->department
    ]);
}

If you'll decide to use update() method, do not forget to add $fillable array.

edited Nov 14, 2016 at 12:50

answered Nov 14, 2016 at 12:47

Alexey Mezenin

164k27 gold badges309 silver badges287 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Alfiza malek Over a year ago

Thanks its working. one question ? function is in same model so may i use $this instead $client.

Alexey Mezenin Over a year ago

If you'll decide to use this code in the model, then yes you should use it like this: return $this->where('id', $id)->update(....);

Alfiza malek Over a year ago

may i use $this->save(); i mean without creating instance.

Alexey Mezenin Over a year ago

You can do this in model: $client = $this->find($id); $client->email = '[email protected]'; $client->save();

Alfiza malek Over a year ago

ok thanks, Will you please explain why i cant use $this- >find; $this->email = '[email protected]'; $this->save(); whats the reason?

gohelyogesh · Accepted Answer · 2016-11-16 05:59:08Z

2

try this example:

    $obj= Client::where('id', $id)->update([
        'name' = $req->name,
        'address' = $req->address,
        'email' = $req->email,
        'phone' = $req->phone,
        'gender' = $req->gender,
        'department' = $req->department
    ]);

answered Nov 16, 2016 at 5:59

gohelyogesh

1497 bronze badges

1 Comment

Alexey Mezenin Over a year ago

Seriously? You checked my answer as best answer, in a day one of your friends copy-pasted my code without any changes and you took it away and checked his answer. Nice behavior.

Collectives™ on Stack Overflow

Laravel save() - inserting the data instead update

2 Answers 2

5 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related