Return same value mutiple times in an array in Javascript

Question

I'm trying to return a value acquired from the following function

function score(string,pattern)
{  
  counter=0
  for(i=0;i<string.length;i++)
  {
    if(string.toUpperCase().substr(i,pattern.length) == pattern.toUpperCase())
      counter++
  }   
  return counter  
}

into the following array

result=[]

for(i=0;i<web.length;i++){
  result[result.length]=score("Coooool!","OO")
  }

such that result=4,4,4 currently, result=4

Any help is appreciated

As @KevinKloet commented: use .push(): result.push(score("what","ever")); — Luuuud
– Luuuud, Commented Nov 17, 2016 at 12:18
You should also consider removing the score function from the question; it is not relevant at all. [Correction: it seems to matter that the value doesn't change, I didn't edit the question though.] — user5734311
– user5734311, Commented Nov 17, 2016 at 12:21
I have rolled back your edit as definition of score is required — Rajesh Dixit
– Rajesh Dixit, Commented Nov 17, 2016 at 12:23

Community · Accepted Answer · 2020-06-20 09:12:55Z

2

Issue is, when you define variables without var, they become part of global scope.

Your Code

function score(string, pattern) {
  counter = 0
  for (i = 0; i < string.length; i++) {
    if (string.toUpperCase().substr(i, pattern.length) == pattern.toUpperCase())
      counter++
  }
  return counter
}

result = []

for (i = 0; i < 4; i++) {
  console.log("Before call: ", i)
  result[result.length] = score("Coooool!", "OO")
  console.log("After call: ", i)
}

console.log(result)

Resolved Code

function score(string, pattern) {
  var counter = 0
  for (var i = 0; i < string.length; i++) {
    if (string.toUpperCase().substr(i, pattern.length) == pattern.toUpperCase())
      counter++
  }
  return counter
}

var result = []

for (var i = 0; i < 4; i++) {
  result[result.length] = score("Coooool!", "OO")
}

console.log(result)

Also as rightly pointed out by kevin kloet, you should use .push instead of result[result.length]

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Nov 17, 2016 at 12:34

Rajesh Dixit

25k5 gold badges52 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user5734311 Over a year ago

In the resolved code, if i remove the var before i in the score function, I'm right back at [4]. Why is this happening?

Rajesh Dixit Over a year ago

It will update i in external for as well. variables are hoisted. So var i will move at top and for would look like for(i=0; i<4; i++)

Shaun Parsons · Accepted Answer · 2016-11-17 12:17:31Z

0

You are indexing your array based on the length rather than the counter. So change it to result[i]=... like below.

result=[]

for(i=0;i<web.length;i++){
    result[i]=score("Coooool!","OO")
}

You could also push to the array:

result=[]

for(i=0;i<web.length;i++){
    result.push(score("Coooool!","OO"))
}

answered Nov 17, 2016 at 12:17

Shaun Parsons

3622 silver badges11 bronze badges

4 Comments

Johny Over a year ago

Thanks for the answer, however both solutions still makes result=4

Kevin Kloet Over a year ago

what is the length of web when you do console.log(web.length)?

Shaun Parsons Over a year ago

What does web look like?

Johny Over a year ago

result=[0,0,0] for(i=0;i<3;i++){ result[i]=score("Coooool!","OO") } seems to return 4,0,0, not 4,4,4

Collectives™ on Stack Overflow

Return same value mutiple times in an array in Javascript

2 Answers 2

Your Code

Resolved Code

2 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Your Code

Resolved Code

2 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related