How to initialize Objective C class variable in init?

Question

In the @interface, I have this declaration:

@interface myClass {
   NSDictionary * myData;
}

@property (nonatomic, assign) NSDictionary * data;
+ (id) initWithData:(NSDictionary *)data;

@end

In the @implementation, I have this code:

@implementation

@synthesize data;

+ (id) initWithData:(NSDictionary *)freshData {
    self = [super init];
    if (self) {
        self->data = freshData;
    }
    return self;
}

@end

But I got error Incomplete definition of type 'struct objc_class on self->data.

If I change it into self.data, I got error Member reference type 'struct objc_class *' is a pointer; did you mean to use '->'?

If I remove the self, I got error `Instance variable 'data' accessed in class method.'

But if I change the method type from + (class method) to - (instance method), I cannot access the init.

And I cannot fix this error by change the assignment from data to myData either.

How should I make a constructor?

The link that I have learned from (but not helping) are:

Rajat · Accepted Answer · 2016-11-25 01:46:26Z

4

You can do it like this also

+ (id) initWithData:(NSDictionary *)freshData {
    return [[self alloc]initWithData:freshData];
}
- (instancetype) initWithData:(NSDictionary *)freshData {

    NSParameterAssert(freshData != nil);

    self = [super init];

    if (self) {
        self.data = freshData;
    }

    return self;
}

answered Nov 25, 2016 at 1:46

Rajat

11.1k4 gold badges42 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Chen Li Yong Over a year ago

If I only implement - (instancetype) initWithData:(NSDictionary *)freshData without + (id) initWithData:(NSDictionary *)freshData, what's the downside?

Rajat Over a year ago

Well you can do that also, if there is not any issue with creating the object ofthat class, as with instance method you need to create the object of that class to use that method and with class method you can call that method with Class.

Rajat Over a year ago

Check this also for class method vs instance method - stackoverflow.com/questions/1053592/…

user1118321 · Accepted Answer · 2016-11-25 02:06:14Z

2

In general, I would not expect an init* method to be a class method. Generally you have a class method with a name like default*, shared*, or *withDictionary:. So for a class named myClass, I'd expect to see this:

+ (myClass*)myClassWithDictionary:(NSDictionary*)dict
{
    return [[myClass alloc] initWithDictionary:dict];
}

This can be important when the static analyzer analyses your code, for example. Naming is significant in Objective-C and hints the compiler (and analyzer) as to what the code's intent is.

answered Nov 25, 2016 at 2:06

user1118321

26.5k4 gold badges60 silver badges89 bronze badges

3 Comments

Chen Li Yong Over a year ago

You mean like [UIColor colorWithCGColor:] ?

user1118321 Over a year ago

Yes, that's what I meant.

Chen Li Yong Over a year ago

Okay, I think I know what's wrong that I can't access instance init method constructor... I forgot to do alloc first before init. That's why I only can access the init method if I changed the init into class constructor, because I immediately wrote [MyClass initWithData:]. I'm so used to Swift simplicity that when I have to go back to Objective C, I kinda forget about the drill... Then your answer reminds me why the init must be instance method, not class method. Thanks!

Community · Accepted Answer · 2017-05-23 12:10:51Z

1

Do not using public init method (+)

+ (id) initWithData:(NSDictionary *)data;

Change to

- (instancetype) initWithData:(NSDictionary *)data;

And I highly recommend you to use instancetype instead of id (reference )

edited May 23, 2017 at 12:10

CommunityBot

11 silver badge

answered Nov 25, 2016 at 1:45

nynohu

1,66813 silver badges13 bronze badges

Collectives™ on Stack Overflow

How to initialize Objective C class variable in init?

3 Answers 3

3 Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related