for loop displays only first item in array

Question

My for loop somehome works only on first item of array but not with rest.

var Cat = function ( name, src, id, clicks) {
 var obj = Object.create(Cat.prototype);
 obj.id = id;
 obj.name = name;
 obj.src = src;
 obj.clicks = clicks;
 return obj;
}
var getCatList = function (array) {
for (let i = 0; i < array.length; i++) {
  console.log(array[i]);
    return array[i].addCat();
  }
}
var Cats = [new Cat("cat-1", "image.src", "cat_1", 0),new Cat("cat-2", "image.src", "cat_2", 0), new Cat("cat-3", "image.src", "cat_3", 0)] 
getCatList(Cats);

You have a return in your for loop, so it will only run once — Mikkel
– Mikkel, Commented Nov 29, 2016 at 12:43

Mark Williams · Accepted Answer · 2016-11-29 12:43:54Z

2

You return out of the loop after the first iteration:

return array[i].addCat();

Not sure what you're trying to do - add a cat to a new array and return it?

answered Nov 29, 2016 at 12:43

Mark Williams

2,3081 gold badge14 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mark Williams Over a year ago

Are you OK doing that (creating the new array and appending), or do you need some help?

Ali Bahrami · Accepted Answer · 2016-11-29 12:45:20Z

1

The return statement in your for block will exit the for iteration after the first one.

var getCatList = function (array) {
for (let i = 0; i < array.length; i++) {
    console.log(array[i]);

    // remove return statement
    // return array[i].addCat();
    array[i].addCat();
  }
}
var Cats = [new Cat("cat-1", "image.src", "cat_1", 0),new Cat("cat-2", "image.src", "cat_2", 0), new Cat("cat-3", "image.src", "cat_3", 0)] 
getCatList(Cats);

answered Nov 29, 2016 at 12:45

Ali Bahrami

6,0833 gold badges36 silver badges53 bronze badges

Comments

Bathsheba · Accepted Answer · 2016-11-29 12:44:01Z

1

Your return in the for loop will exit the function.

You meant to write array[i].addCat(); as the statement, surely?

answered Nov 29, 2016 at 12:44

Bathsheba

235k35 gold badges376 silver badges504 bronze badges

Comments

ΦXocę 웃 Пepeúpa ツ · Accepted Answer · 2016-11-29 13:06:11Z

0

No matter how many elements the array is holding

doing this

for (let i = 0; i < array.length; i++) {
  console.log(array[i]);
    return array[i].addCat();
  }

will execute ONLY the first boucle in the loop,

answered Nov 29, 2016 at 13:06

ΦXocę 웃 Пepeúpa ツ

48.4k17 gold badges77 silver badges102 bronze badges

Comments

Yosvel Quintero · Accepted Answer · 2016-11-29 13:58:56Z

0

If you call return within a for loop, it will stops the execution and exits the function.

To get an array of Cats out of getCatList method you can use Array.prototype.map():

Code:

var Cat = function (name, src, id, clicks) {
      var obj = Object.create(Cat.prototype);
      obj.id = id;
      obj.name = name;
      obj.src = src;
      obj.clicks = clicks;
      return obj;
    },
    getCatList = function (array) {
      return array.map(function (el) {
        return el;
      });
    },
    Cats = [new Cat("cat-1", "image.src", "cat_1", 0), new Cat("cat-2", "image.src", "cat_2", 0), new Cat("cat-3", "image.src", "cat_3", 0)];

console.log(getCatList(Cats));

ES6:

  let getCatList = array => array.map(el => el);

edited Nov 29, 2016 at 13:58

answered Nov 29, 2016 at 13:01

Yosvel Quintero

19.1k5 gold badges39 silver badges47 bronze badges

Collectives™ on Stack Overflow

for loop displays only first item in array

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related