if condition in javascript using variables

Question

The problem with this code is when I'm executing the if condition. The condition only works if i am using if (pixel.getx() <=100) but does not work for a var x = pixel.getX() & if (x <= 100). Can someone tell me why?

var image = new SimpleImage (200,200);
print (image);

for (var pixel of image.values())
var x = pixel.getX();
var y = pixel.getY()

if (x <= 100 && y <= 100)

{
pixel.setRed(255);
pixel.setBlue(0);
pixel.setGreen(0);  
}

else if (x > 100)
{
pixel.setBlue(255);
pixel.setGreen(0);
pixel.setRed(0);
}   
print (image);

What is SimpleImage? getx and getX are two different methods. Is that the issue? Or just a typo in the question? — Felix Kling
– Felix Kling, Commented Dec 2, 2016 at 1:19
Your for (var pixel of image.values()) loop isn't using { braces } and therefore operates only on the next statement after it, var x = pixel.getX(); The rest of your code, including the if statement, is not part of the loop. — Stephen P
– Stephen P, Commented Dec 2, 2016 at 1:23
var x = pixel.getX() & if (x <= 100) is not valid syntax, so that's an issue — Jaromanda X
– Jaromanda X, Commented Dec 2, 2016 at 1:25

classicalConditioning · Accepted Answer · 2016-12-02 01:24:11Z

2

your for loop is missing {}. all it does the way you have it in your example is executing var x = pixel.getX(); as many times as there are image.values()

if you need to repeat a multi line block of code within a for loop it needs to be inside {}

if you are repeating one statement - you don't need {} - that's why it worked when you had if (pixel.getX() <= 100) {...}

answered Dec 2, 2016 at 1:24

classicalConditioning

6557 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

marcan2020 · Accepted Answer · 2016-12-02 02:34:47Z

2

Your for loop is missing the braces { } and that's why its not working.

Modified code,

var image = new SimpleImage (200,200);
print (image);

for (var pixel of image.values()) {
    var x = pixel.getX();
    var y = pixel.getY()

    if (x <= 100 && y <= 100) {
        pixel.setRed(255);
        pixel.setBlue(0);
        pixel.setGreen(0);  
    } else if (x > 100) {
        pixel.setBlue(255);
        pixel.setGreen(0);
        pixel.setRed(0);
    }   

    print (image);
}

edited Dec 2, 2016 at 2:34

marcan2020

6096 silver badges14 bronze badges

answered Dec 2, 2016 at 1:25

Aruna

12k3 gold badges31 silver badges42 bronze badges

Collectives™ on Stack Overflow

if condition in javascript using variables

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related