javascript fail - regexp bug

Question

Hei all

I have this code

function prototype( str , id )
{
    var ret = str;

    ret = ret.replace( /ø/g, 'oe' );
    ret = ret.replace( /Ø/g, 'OE' );
    ret = ret.replace( /å/g, 'aa' );
    ret = ret.replace( /Å/g, 'AA' );
    ret = ret.replace( /æ/g, 'ae' );
    ret = ret.replace( /Æ/g, 'AE' );

    document.getElementById( id ).value = ret.replace(/[^a-zA-Z0-9\/\_-]/i,'_').replace(/_+/g,'_');
}

My problem is now, if i use word like this (demo demo demo) its okay make this word to (demo_demo demo)

i use this function to escape urls. the next i need its send it to lower case, after I'm done, i hope for help :)

tanks a lot all.

I'm not entirely sure what you're asking. What's the problem with your script? — Nathan
– Nathan, Commented Nov 10, 2010 at 12:38

Dr.Molle · Accepted Answer · 2010-11-10 12:41:20Z

2

You forgot the greedy-modifier

/[^a-zA-Z0-9\/\_-]/i

....

/[^a-zA-Z0-9\/\_-]/ig

answered Nov 10, 2010 at 12:41

Dr.Molle

117k16 gold badges200 silver badges206 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gabriele Petrioli · Accepted Answer · 2010-11-10 12:41:58Z

2

If the problem is that only the first space gets replaced with _, then you need to put the g option to the regex replace.

ret.replace(/[^a-zA-Z0-9\/\_-]/gi,'_')

to turn the string to lower case use the

toLowerCase() method of strings.

answered Nov 10, 2010 at 12:41

Gabriele Petrioli

197k35 gold badges275 silver badges331 bronze badges

Comments

Chinmayee G · Accepted Answer · 2010-11-10 12:42:46Z

1

Assuming that your 1st requirement is to replace space, +, - characters with underscore,

document.getElementById( id ).value = ret.replace(/[^a-zA-Z0-9\/\_-]/ig,'_').replace(/_+/ig,'_');

Other requirement is to make it lowercase string

document.getElementById( id ).value = document.getElementById( id ).value.toLowerCase();

answered Nov 10, 2010 at 12:42

Chinmayee G

8,1172 gold badges34 silver badges41 bronze badges

Comments

fcalderan · Accepted Answer · 2010-11-10 12:50:55Z

0

The main potential issue I see, is on first replacement (on Ø and other scandinavian characters).

you should change with unicode char representation, e.g. this statement

ret = ret.replace( /Ø/g, 'OE' );

should be

ret = ret.replace( /\u0153/g, 'OE' );

for other diacritic signs just find a unicode chart like http://www.chucke.com/entities.html

answered Nov 10, 2010 at 12:50

fcalderan

Collectives™ on Stack Overflow

javascript fail - regexp bug

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related