JAVA: Add new parameter to a method

Question

I have a method addNewUser which asks for users Username, Email and Password. Those will be stored in the excel sheet on its corresponding columns. Please see code below:

public class ExcelConfig {



public FileInputStream fis;
public FileOutputStream fos;
public XSSFWorkbook wb;
public XSSFSheet sh;
public XSSFRow row;
public XSSFCell cell;

int lastRow = 0;

ConfigReader cr = new ConfigReader();

public ExcelConfig(){

      try {
        fis = new FileInputStream(cr.getExcelPath());
        wb = new XSSFWorkbook(fis);
       } 
       catch (Exception e) {
        System.out.println("Error at ExcelConfig " + e.getMessage());
       }


}


public void addNewUser(String un, String em, String pw){


      cell = row.createCell(0);
      cell.setCellValue(un);

      cell = row.createCell(1);
      cell.setCellValue(em);

      cell = row.createCell(2);
      cell.setCellValue(pw);


}

}

Now, in other class, I called addNewuser method. See code below

public class NextStepTest {

WebDriver driver;

ConfigReader cf;
ExcelConfig ec;
UserDetails ud;

LandingPage lp;
RegisterPage rp;

String username;
String email;
String password;




@BeforeTest
public void setUp(){
    cf = new ConfigReader();
    ec = new ExcelConfig();
    ud = new UserDetails();


    driver = cf.getChromeDriver();
    driver.get(cf.getAppUrl());


}

@Test
public void register(){

    username = cf.getUsernameFromProperty();
    email = cf.getEmailFromProperty();
    password = ud.getPassword();

    try{

        lp = new LandingPage(driver);
        lp = PageFactory.initElements(driver, LandingPage.class);

        lp.locateRegisterLink();
        lp.clickRegisterLink();

        rp = new RegisterPage(driver);
        rp = PageFactory.initElements(driver, RegisterPage.class);


        rp.locateUsernameField();
        rp.registerAccount(username, email, password);


        ec.getSheet(0);
        ec.getNextRow();
        ec.addNewUser(username, email, password); // here I call addNewUser method that now has username, email and password values
        ec.closeFile();

        rp.logout();
        lp.locateLoginLink();



    }
    catch(Exception e){
        System.out.println("Error under NextStepTest.java => " + e.getMessage());

    }



}

Now, what I want to ask is that is it possible to make addNewUser method parameters dynamic? I know that this scenario is project dependent. Some project may require only username, email and password in this case to be added on excel. What if in the other future project , it will require to add an account type? So the parameters will now become 4. Or other projects will only require email and a password. Should I update addNewUser method parameters every time? I'm still a starter in this language. Any help will do. Thanks everyone!

Let your method accept a vararg: String ... args. And please learn Java a bit. — Egor Zhuk
– Egor Zhuk, Commented Feb 23, 2017 at 9:35
Maybe your addNewUser should accept some kind of NewUserParameters object. You can build such an object with whatever parameters you need in the given context, and then pass it to your method. See also builder pattern — khelwood
– khelwood, Commented Feb 23, 2017 at 9:38
You may just pass your parameters as a User object and inside it you can pass whatever parameter you want. If you want to add more properties you can do so by adding those to your User class. — Nope
– Nope, Commented Sep 20, 2018 at 11:03

ΦXocę 웃 Пepeúpa ツ · Accepted Answer · 2017-02-23 09:41:24Z

1

What if in the other future project , it will require to add an account type?

then in the future you will need to overload the method

public void addNewUser(String un, String em, String pw){

}

//only username
public void addNewUser(String un){

}

//with all the info + token
public void addNewUser(String un, String em, String pw, String token){

}

the only thing you need to be aware is: those are all Strings... so you need to know in forehand what string is to which parameter...

answered Feb 23, 2017 at 9:41

ΦXocę 웃 Пepeúpa ツ

48.4k17 gold badges77 silver badges102 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

naib khan · Accepted Answer · 2017-02-23 10:20:16Z

1

You can use map as parameter.this will help you pass parameter dynamically.

 public void addNewUser(Map<String, Object> mapInput){
    Iterator entries = mapInput.entrySet().iterator();
    int i=0;
    while (entries.hasNext()) {
        Entry thisEntry = (Entry) entries.next();
        String value = (String)thisEntry.getValue();
        cell = row.createCell(i);
        cell.setCellValue(value);
        i++;
    }
}

answered Feb 23, 2017 at 10:20

naib khan

1,14811 silver badges19 bronze badges

Comments

kamehl23 · Accepted Answer · 2017-02-23 09:37:38Z

0

You could create an Interface AddNewUser, that has a method createUser that returns for example the created XSSFRow row.

Then you create an implementation of that interface ,e.g. AddUserWithEmail, that gets the specific values in constructor and then in createUser method adds the user and email to the row.

If you have another customer who needs different values in table you just create a new variant of the AddNewUser interface and use it instead.

answered Feb 23, 2017 at 9:37

kamehl23

5223 silver badges6 bronze badges

Comments

Cedric Franck · Accepted Answer · 2017-02-23 09:43:12Z

0

Yes it is possible. By using thi variable arguments parameter :

public void foo(String... strings){
    // method body
}

so with this functions you can call :

foo("name");
foo("name", "account");
foo("name", "account", "age");

etc...

And usings this arguments like this:

public void foo(String... strings) {
        if (0 < strings.length()) {
            String name = strings[0];
        }
        if (1 < strings.length()) {
            String account = strings[1];
        }
        if (2 < strings.length()) {
            String account = strings[2];
        }
        // etc
    }

Hope this helps.

answered Feb 23, 2017 at 9:43

Cedric Franck

5264 silver badges9 bronze badges

Collectives™ on Stack Overflow

JAVA: Add new parameter to a method

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related