Getting variable OUT of jquery.each() function

Question

I have the following search function:

function filter() {
    $("table#list tr").each(function () {
        var search = $("#search").val();
        var name = $(this).find("span.name").html();
        var email = $(this).find("span.email").html();
        var ref = $(this).find("span.reference").html();
        var match = false;
        var count = 0;
        if((name != undefined) && (email != undefined) && (ref != undefined)) {
            if(name.indexOf(search) >= 0) match = true;
            if(email.indexOf(search) >= 0) match = true;
            if(ref.indexOf(search) >= 0) match = true;
            if(match) {
                $(this).removeClass("collapse");
                count++;
            } else {
                $(this).addClass("collapse");
            }
        }
    }); 
    $("#result-count").html(count + " results found.");
}

However on the last line, count is undefined, because I created it inside the function. How can I get the value outside of the $.each function?

Edit: I also just realized I'm resetting the count inside the loop so it will always = 0! How can I count the results properly?

put var count = 0; outside .each()

guradio
– guradio

2017-04-26 07:30:35 +00:00
Commented Apr 26, 2017 at 7:30 — guradio
– guradio, Commented Apr 26, 2017 at 7:30

Rory McCrossan · Accepted Answer · 2017-04-26 07:36:01Z

1

Declare count outside the each block. Also note that you can tidy up the logic a little too:

var count = 0;

$("table#list tr").each(function () {
  var search = $("#search").val();
  var name = $(this).find("span.name").html();
  var email = $(this).find("span.email").html();
  var ref = $(this).find("span.reference").html();

  if (name == undefined || email == undefined || ref == undefined)
    return;

  if (name.indexOf(search) >= 0 || email.indexOf(search) >= 0 || ref.indexOf(search) >= 0) {
    $(this).removeClass("collapse");
    count++;
  } else {
    $(this).addClass("collapse");
  }
}); 

$("#result-count").html(count + " results found.");

edited Apr 26, 2017 at 7:36

answered Apr 26, 2017 at 7:30

Rory McCrossan

338k41 gold badges322 silver badges353 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Amir H. Bagheri · Accepted Answer · 2017-04-26 07:30:10Z

As you said, just have it off the each loop:

function filter() {
   var count =0; // put it here
$("table#list tr").each(function () {
    var search = $("#search").val();
    var name = $(this).find("span.name").html();
    var email = $(this).find("span.email").html();
    var ref = $(this).find("span.reference").html();
    var match = false;
    if((name != undefined) && (email != undefined) && (ref != undefined)) {
        if(name.indexOf(search) >= 0) match = true;
        if(email.indexOf(search) >= 0) match = true;
        if(ref.indexOf(search) >= 0) match = true;
        if(match) {
            $(this).removeClass("collapse");
            count++;
        } else {
            $(this).addClass("collapse");
        }
    }
}); 
$("#result-count").html(count + " results found.");
}

ChenLee · Accepted Answer · 2017-04-26 07:30:12Z

function filter() {
    var count = 0;
    $("table#list tr").each(function () {
        var search = $("#search").val();
        var name = $(this).find("span.name").html();
        var email = $(this).find("span.email").html();
        var ref = $(this).find("span.reference").html();
        var match = false;
        if((name != undefined) && (email != undefined) && (ref != undefined)) {
            if(name.indexOf(search) >= 0) match = true;
            if(email.indexOf(search) >= 0) match = true;
            if(ref.indexOf(search) >= 0) match = true;
            if(match) {
                $(this).removeClass("collapse");
                count++;
            } else {
                $(this).addClass("collapse");
            }
        }
    }); 
    $("#result-count").html(count + " results found.");
}

Collectives™ on Stack Overflow

Getting variable OUT of jquery.each() function

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related