ArrayList implementation in PHP

Question

I have tried implementing the basic features of ArrayList (Java ) in PHP .The Arraylist should be capable of adding any type of object (generic as in Java) Can anyone give suggestion for improvement in design/implementation. Here is the code

<?php
/* 
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

class ArrayList
{

    private $arrVar;

    function  __construct($option)
    {
        $this->arrVar = array();
        array_push($this->arrVar,$option);
    }

  function addValue($option)
  {
      array_push($this->arrVar,$option);
  }

    function getLastValue()
  {
      $arr = array_pop($this->arrVar);
      return $arr;
  }

}



?>

Why can't you use normal PHP arrays? They can contain objects of any type without you having to specify what type. — BoltClock
– BoltClock, Commented Dec 8, 2010 at 16:53
array_pop deletes the last element of the array, but you function says getLastValue() — Phill Pafford
– Phill Pafford, Commented Dec 8, 2010 at 17:01
I suspect that the customized functions you want to write could be written using an iterator. See here for an example of using them with an array of objects. — Spudley
– Spudley, Commented Dec 8, 2010 at 17:04

dicroce · Accepted Answer · 2010-12-08 16:57:22Z

2

Your class doesn't really do anything other than restrict the operations I can perform on the array. It's usually best to adopt the idioms common for a particular language, rather than trying to get the language to resemble some other language you prefer.

answered Dec 8, 2010 at 16:57

dicroce

47.1k31 gold badges107 silver badges151 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

theazureshadow Over a year ago

Not to mention that it neither follows the naming conventions for ArrayList nor implements a minimal useful subset of its members.

Phill Pafford · Accepted Answer · 2010-12-08 17:16:57Z

Don't know if this helps:

class MyArray {
   private $my_array;

   function  __construct() {
      $this->my_array = array();
   }

   public function setMyArray($value) {
      $this->my_array = $value;
   }

   public function getMyArray() {
      return $this->my_array;
   }

   public function getLastElement() {
      $last_elem = array_reverse($this->getMyArray());
      return $last_elem[0];
   }
}

$myArr = new MyArray();
$a[] = "Hello"; // use this instead of array_push
$a[] = "World";
$myArr->setMyArray($a);
echo "My Array:<pre>".print_r($myArr->getMyArray(),true)."</pre><br />\n";
echo "Last Element: ".$myArr->getLastElement()."<br />\n";

$a[] = "Yet another element";
$myArr->setMyArray($a);
echo "My Array Again:<pre>".print_r($myArr->getMyArray(),true)."</pre><br />\n";
echo "Last Element Again: ".$myArr->getLastElement()."<br />\n";

Output:

My Array:Array
(
    [0] => Hello
    [1] => World
)

Last Element: World

My Array Again:Array
(
    [0] => Hello
    [1] => World
    [2] => Yet another element
)

Last Element Again: Yet another element

Collectives™ on Stack Overflow

ArrayList implementation in PHP

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related