Create multiple file in PHP using foreach loop for array created using file() function

Question

I am trying to create multiple files in PHP using a foreach loop. The foreach loop reads the contents of an array, which is formed using file() function from a text(.txt) file. The loop is supposed to create a [.php] file with EACH of the value in the array, but it is creating the file for ONLY the LAST value in the array.

<?php
$user_list=file('users.txt');
$n=0;
foreach ($user_list as $user[$n]) {
if(!file_exists("Users/".$_POST[username]."-".$user[$n].".php")){
$file_c=fopen("Users/".$_POST[username]."-".$user[$n].".php", 'a+'); 
fwrite($file_c,"Content");  
}
$n++;
} 
?>

whats the output of $user_list?

Rafael Shkembi
– Rafael Shkembi

2017-05-29 08:43:44 +00:00
Commented May 29, 2017 at 8:43 — Rafael Shkembi
– Rafael Shkembi, Commented May 29, 2017 at 8:43
Rafael Shkembi the output is correct, exactly what I want.

Mrigank Pawagi
– Mrigank Pawagi

2017-05-29 08:56:58 +00:00
Commented May 29, 2017 at 8:56 — Mrigank Pawagi
– Mrigank Pawagi, Commented May 29, 2017 at 8:56

Mohammad Hamedani · Accepted Answer · 2017-05-29 09:35:40Z

1

If you work with multiple fwrite(), need to be close file handler by fclose() after writing file was completed:

<?php
    $user_list=file('users.txt');

    foreach ($user_list as $user) {
        if(!file_exists("Users/".$_POST[username]."-".trim($user).".php")){
            $file_c=fopen("Users/".$_POST[username]."-".trim($user).".php", 'a'); 
            fwrite($file_c,"Content");
            fclose($file_c);
        }

    } 
?>

edited May 29, 2017 at 9:35

answered May 29, 2017 at 8:47

Mohammad Hamedani

3,3543 gold badges13 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Mrigank Pawagi Over a year ago

I used fclose() after you said, still only the LAST value is printed.

Mrigank Pawagi Over a year ago

I removed the counter($n) but that still didn't help. It even created problem when I was printing [hyperlinks]. Still only the last value's file is created.

Mohammad Hamedani Over a year ago

User a instead of a+ parameter of fopen()

Mrigank Pawagi Over a year ago

I used the parameters 'a' , 'x' and 'w' as well, still no good. :(

Mohammad Hamedani Over a year ago

how $user_list=file('users.txt'); return array? It's string! What's content of users.txt file?

|

Reiah Paul Sam · Accepted Answer · 2017-05-29 09:21:46Z

0

The problem is as you are reading from text file, there have a lot of chance of adding a space suffixed with the data in the array., i used trim() method and it worked fine for me, A suggestion, use file_exists () function to check if directory exists. the following code worked for me i hard coded the user name .

<?php
    $user_list=file('users.txt');
    $username = 'sdcds';

    foreach ($user_list as $user) {
        if(!file_exists('Users/'.$username."-".trim($user).".php")){

            $file_c = fopen('Users/'.$username."-".trim($user).".php", 'a+'); 
            fwrite($file_c,"Content");
            fclose($file_c);
        }

    } 
?>

answered May 29, 2017 at 9:21

Reiah Paul Sam

5656 silver badges16 bronze badges

2 Comments

Reiah Paul Sam Over a year ago

@Mrigank Pawagi try this once

Mrigank Pawagi Over a year ago

Thanks a lot bro..! I used trim and now ALL the files are created. Thanks a lot for your help. Just check out mrigankpawagi.github.io one my project is finished!

Collectives™ on Stack Overflow

Create multiple file in PHP using foreach loop for array created using file() function

2 Answers 2

6 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related