I think below code can be simpleer somehow. Can this code be optimized?
let name = app.short_name;
if (name === undefined) {
name = app.name;
if (name === undefined) {
name = 'Untitled';
}
}
3 Answers
Use Logical OR (||) operator
let name = app.short_name || app.name || 'Untitled';
Comments
You could use a default chain with logical OR || in a short-circuit evaluation.
let name = app.short_name || app.name || 'Untitled';
But I suggest to use a variable name different of name, because it is usually a property of window
Comments
Javascript will assign what it considers true. If you concat with || (OR) then each value is checked for true until a true value is found and is assigned.
There are a number of values that become false for example:
undefined0null''(empty String)NaN
This is why you could write
let name = app.short_name || app.name || 'Untitled';
because if app.short_name has a value it will be true rather than false and it is assigned. But if it is undefined it will be considered false and app.name will be checked if it is true. If it is undefined it will be again considered false and so finally 'Untitled' is considered and deemed true and assigned to name. Might want to look at this link.
1 Comment
RNA
appreciate you for the additional infomation. helped me to learn :)
namecould ben:plet name = app.short_name || app.name || 'Untitled';