PHP loop to create an HTML table

Question

I have an array which is populated from a MySQL query:

if ($result) {
    $foundResult = true;
    foreach ($result as $row) {
        array_push($searchResultAccount,$row->Account);
        array_push($searchResultUsername,$row->Username);
        array_push($searchResultPassword,$row->Password);
        array_push($searchResultCreated,$row->Created);
        array_push($searchResultStrength,$row->Strength);
    }
} else {
    array_push($error,"No results found");
}

Further down in my page, I want to create a table and populate the bootstrap table with the results from the array. However, each cell in the table prints all sets of results for that given field. I suspect I have a problem with my loop logic. I tried changing from a foreach to a for loop but still no luck:

<tbody>
  <?php for ($x = 0; $x < sizeof($result); $x++) { ?>
    <tr>
      <td><?php for ($i = 0; $i < sizeof($searchResultAccount); $i++){echo($searchResultAccount[$i]);}?></td>
      <td><?php for ($i = 0; $i < sizeof($searchResultUsername); $i++){echo($searchResultUsername[$i]);}?></td>
      <td><?php for ($i = 0; $i < sizeof($searchResultPassword); $i++){echo($searchResultPassword[$i]);}?></td>
      <td><?php for ($i = 0; $i < sizeof($searchResultCreated); $i++){echo($searchResultCreated[$i]);}?></td>
      <td><p>ExpiresHere</p></td>
      <td><?php for ($i = 0; $i < sizeof($searchResultStrength); $i++){echo($searchResultStrength[$i]);}?></td>
    </tr>
  <?php } ?>
</tbody>

The outcome looks like below:

I have 2 results in the array, and as you can see they're printing together in each cell. Any ideas on where I've went wrong ?

Edit: Full PHP code as from the query string below:

$sql = "SELECT * FROM Accounts WHERE User_ID = :userid AND Account = :account";
    $stmt = $pdo->prepare($sql);

    $stmt->bindValue(':userid',$userid);
    $stmt->bindValue(':account',$account);
    $stmt->execute();
    $result = $stmt->fetchAll(PDO::FETCH_CLASS);

    if($result) {
        $foundResult = true;
        foreach($result as $row) {
            array_push($searchResultAccount,$row->Account);
            array_push($searchResultUsername,$row->Username);
            array_push($searchResultPassword,$row->Password);
            array_push($searchResultCreated,$row->Created);
            array_push($searchResultStrength,$row->Strength);
        }
    } else {
        array_push($error,"No results found");
    }

Can you post the full PHP code starting from the query string? — Praveen Kumar Purushothaman
– Praveen Kumar Purushothaman, Commented Dec 10, 2017 at 11:52

Majid Abbasi · Accepted Answer · 2017-12-10 11:54:40Z

2

Work like this:

foreach($result as $row) {
    ?>
        <tr>
           <td><?php echo $row->Account; ?></td>
           <td><?php echo $row->Username; ?></td>
           <td><?php echo $row->Password; ?></td>
           <td><?php echo $row->Created; ?></td>
           <td><?php echo $row->Strength; ?></td>
        </tr>
    <?php
}

with this approach you create table row for each result row

answered Dec 10, 2017 at 11:54

Majid Abbasi

1,5313 gold badges12 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

JamMan9 Over a year ago

Thank you so much. Works perfect. Really appreciate the help. Will mark your answer.

Aleksandar Đokić · Accepted Answer · 2017-12-10 11:56:37Z

1

You have to remove your for loops inside of td elements

foreach($result as $row) {
        <tr>
           <td><?php echo $row->Account;?></td>
           <td><?php echo $row->Username;?></td>
           <td><?php echo $row->Password;?></td>
           <td><?php echo $row->Created;?></td>
           <td><?php echo $row->Strength;?></td>
        </tr>
}

answered Dec 10, 2017 at 11:56

Aleksandar Đokić

2,39921 silver badges40 bronze badges

Comments

user8979341 · Accepted Answer · 2017-12-10 11:58:09Z

1

The problem is occurring because of lines like this.

for($i = 0; $i < sizeof($searchResultAccount); $i++){echo($searchResultAccount[$i]);}

I'm "guessing" that the problem is occurring because this is the length of the rows you want to print, not the count of data you want the print on the table.

Try changing the rows from:

<?php for($i = 0; $i < sizeof($searchResultAccount); $i++){echo($searchResultAccount[$i]);}?>

into

<td><?php echo($searchResultAccount[$x]) ; } ?></td>

answered Dec 10, 2017 at 11:58

user8979341

Comments

Luke Hol · Accepted Answer · 2017-12-10 12:02:47Z

1

You are now looping trough each result in each tablerow (tr). With this code, you are only focussing the result that belongs to the tr.

<tbody>
  <?php for($x = 0; $x < sizeof($result); $x++) { ?>
    <tr>
      <td><?php echo($searchResultAccount[$x]);?></td>
      <td><?php echo($searchResultUsername[$x]);?></td>
      <td><?php echo($searchResultPassword[$x]);?></td>
      <td><?php echo($searchResultCreated[$x]);?></td>
      <td><p>ExpiresHere</p></td>
      <td><?php echo($searchResultStrength[$x]);?></td>
    </tr>
  <?php } ?>
</tbody>

answered Dec 10, 2017 at 12:02

Luke Hol

1408 bronze badges

Collectives™ on Stack Overflow

PHP loop to create an HTML table

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related