PHP loop - creating a table using a loop and giving it headers

Question

I am a few stages further in learning PHP but I have come to another annoying pit stop. I have a really simple bit of code that retrieves book items from my database. I am displaying them in an html table however because it is a loop, if I use the th tags for table header I get a header above every single data item!

Here is my code extract: (as you can see I have put my th tags as comments as that doesn't work)

<table border="0">
<br />
<?php
$count = 0;
while ($count < $numrow)
{
    $row = mysql_fetch_array($results);
    extract($row);

    echo "<tr>";

    //echo "<tr>";
    //echo "<th>";
    //echo "Book Title";
    //echo "</th>";
    //echo "<th>";
    //echo "Book Author";
    //echo "</th>";
    //echo "<th>";
    //echo "Book Publisher";
    //echo "</th>";
    //echo "<th>";
    //echo "Book ISBN";
    //echo "</th>";
    //echo "</tr>";

    echo "<td>";
    echo "<a href='addtolist.php?     bookname=".$bookname."&bookauthor=".$bookauthor."&bookpub=".$bookpub."&bookisbn=".$bookisbn."'>[+]</a>";

    echo "</td>";

    echo "<td>";
    echo $bookname;
    echo "</td>";

    echo "<td>";
    echo $bookauthor;
    echo "</td>";

    echo "<td>";
    echo $bookpub;
    echo "</td>";

    echo "<td>";
    echo $bookisbn;
    echo "</td>";

    echo "<td>";
    echo "<a href='deletecd.php?bookname=".$bookname."'>Delete</a>";
        echo "</td>";

    echo "</tr>";

    $count = $count + 1;

}
?>

jprofitt · Accepted Answer · 2012-02-21 21:29:28Z

2

Move those echos out of your loop. Also, you shouldn't have a <br /> directly inside of a <table> tag.

answered Feb 21, 2012 at 21:29

jprofitt

11k4 gold badges38 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Phil Over a year ago

I did notice as soon as I posted question, will remove br.. Thank you for response, will tick your answer as soon as it allows me too!many thanks [=

jprofitt Over a year ago

That's how it usually happens! ;)

Diodeus - James MacFarlane · Accepted Answer · 2012-02-21 21:29:25Z

1

Move your table header code outside of the loop.

answered Feb 21, 2012 at 21:29

Diodeus - James MacFarlane

115k33 gold badges164 silver badges180 bronze badges

Comments

Phil · Accepted Answer · 2012-02-21 21:29:08Z

0

IDIOT! Sorry guys....

Needed to put the th tags outside of the loop.... simple I know but easy to miss when your learning!

[=

answered Feb 21, 2012 at 21:29

Phil

1,4635 gold badges24 silver badges42 bronze badges

1 Comment

Diodeus - James MacFarlane Over a year ago

I guess knowing the difference between "your" and "you're" would be helpful some for some of us too.

Matt Lo · Accepted Answer · 2012-02-21 21:29:52Z

0

Simply take the header outside the loop, so echo before you begin your loop but after the opening<table>

answered Feb 21, 2012 at 21:29

Matt Lo

5,7511 gold badge25 silver badges23 bronze badges

Comments

MarcinJuraszek · Accepted Answer · 2012-02-21 21:29:58Z

You have to move the headers above the loop:

<table border="0">
<tr>
<th>Book Title</th>
<th>Book Author</th>
<th>Book Publisher</th>
<th>Book ISBN</th>
</tr>

    <?php
    $count = 0;
    while ($count < $numrow)
    {
        $row = mysql_fetch_array($results);
        extract($row);

    echo "<tr>"

        echo "<td>";
        echo "<a href='addtolist.php?     bookname=".$bookname."&bookauthor=".$bookauthor."&bookpub=".$bookpub."&bookisbn=".$bookisbn."'>[+]</a>";

        echo "</td>";

        echo "<td>";
        echo $bookname;
        echo "</td>";

        echo "<td>";
        echo $bookauthor;
        echo "</td>";

        echo "<td>";
        echo $bookpub;
        echo "</td>";

        echo "<td>";
        echo $bookisbn;
        echo "</td>";

        echo "<td>";
        echo "<a href='deletecd.php?bookname=".$bookname."'>Delete</a>";
            echo "</td>";

        echo "</tr>";

        $count = $count + 1;

    }
    ?>

Eugen Rieck · Accepted Answer · 2012-02-21 21:30:39Z

0

<table border="0">
<tr>
<th>Book Title</th>
<th>Book Author</th>
<th>Book Publisher</th>
<th>Book ISBN</th>
</tr>
<?php
$count = 0;
while ($count < $numrow)
{
    $row = mysql_fetch_array($results);
    extract($row);

    echo "<tr>";


    echo "<td>";
...

What is static, stays static. Wjat is dynamic, becomes PHP

answered Feb 21, 2012 at 21:30

Eugen Rieck

65.6k10 gold badges75 silver badges97 bronze badges

Collectives™ on Stack Overflow

PHP loop - creating a table using a loop and giving it headers

6 Answers 6

2 Comments

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related