c# constructor default parameters correct way

Question

So I need to understand which way is the correct/best one?

First way:

class Customer
{
    string firstName;
    string lastName;

    public Customer(string firstName="non", string lastName="applicable")
    {
        this.firstName = firstName;
        this.lastName = lastName;
    }
}

Second way:

class Customer
{
    string firstName;
    string lastName;

    public Customer()
    : this("non","applicable")
    { }

    public Customer(string firstName, string lastName)
    {
        this.firstName = firstName;
        this.lastName = lastName;
    }
}

If I'm creating a method printFullName(), it works in both cases. So which one to chose? The first one seems easier to me.

There are many "overload vs optional parameters" questions, but parameterless constructor might be a bit more special you think? — Sinatr
– Sinatr, Commented Jan 11, 2018 at 11:18
I don't think there's any big difference, so choose the one that is clearer for you. This question seems to fall into "primarily opinion based" category. — Pikoh
– Pikoh, Commented Jan 11, 2018 at 11:21
Taking serialization into account, I think you may want to have parameterless constructor. — Sinatr
– Sinatr, Commented Jan 11, 2018 at 11:25
@Pikoh There is a difference - what would happen if you called both with new Customer("Jim", null) ? — ZippyZippedUp
– ZippyZippedUp, Commented Jan 11, 2018 at 11:25
@ZippyZippedUp yep, you're right. I realized that would be a problem after Scott Hannen answer. — Pikoh
– Pikoh, Commented Jan 11, 2018 at 11:27

h-rai · Accepted Answer · 2018-01-11 11:36:09Z

11

In terms of semantics, both ways are correct. Some of the differences between the two are

First way: Invoke the constructor as:

new Customer(firstName="first");
new Customer(lastName="last");
new Customer("first", "last");
new Customer();

Second way: Invoke the constructor as:

new Customer("first", "last");
new Customer();

So the first way will give you more flexibility in how you can invoke the constructor.

answered Jan 11, 2018 at 11:36

h-rai

4,0548 gold badges56 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Scott Hannen · Accepted Answer · 2018-01-11 11:27:30Z

The second way is better, because it looks like it's your intent to use "non" and "applicable" as the first and last name if they supply no inputs.

If you have just one constructor with optional arguments, someone could supply a first name and have the last name be "applicable," like "Bob applicable."

It's a minor difference because a) it works either way, and b) a consumer can tell what the default parameters are. But the second option seems more in line with your apparent intent.

To be really particular I'd reconsider those defaults. Should someone be able to create a customer without a name? If so then perhaps the name should be null. Perhaps CustomerName should be a separate class, and Customer has a Name property of of type CustomerName. The reason I'm splitting hairs over that is because you want to know if you have a name or not. Once you supply a fake name that's harder to determine. You could send out hundreds of letters to customers named "non applicable."

Collectives™ on Stack Overflow

c# constructor default parameters correct way

First way:

Second way:

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

First way:

Second way:

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related