Writing a file in Java

Question

Good day!

I have a project (game) that needs to be presented tomorrow morning. But I discovered a bug when writing in the high scores. I am trying to create a text file and write the SCORE NAME in descending order using score as the basis.

FOR EXAMPLE:

SCORE   NAME           RANK
230     God
111     Galaxian     
10      Gorilla
5       Monkey
5       Monkey
5       Monkey

NOTE THERE'S ALSO A RANK My code is as follows:

  public void addHighScore() throws IOException{
        boolean inserted=false;

        File fScores=new File("highscores.txt");
        fScores.createNewFile();

        BufferedReader brScores=new BufferedReader(new FileReader(fScores));
        ArrayList vScores=new ArrayList();
        String sScores=brScores.readLine();
        while (sScores!=null){
                if (Integer.parseInt(sScores.substring(0, 2).trim()) < score &&     inserted==false){
                        vScores.add(score+"\t"+player+"\t"+rank);
                        inserted=true;
                }
                vScores.add(sScores);
                sScores=brScores.readLine();
        }
        if (inserted==false){
                vScores.add(score+"\t"+player+"\t"+rank);
                inserted=true;
        }
        brScores.close();

        BufferedWriter bwScores=new BufferedWriter(new FileWriter(fScores));
        for (int i=0; i<vScores.size(); i++){
                bwScores.write((String)vScores.get(i), 0, ((String)vScores.get(i)).length());
                bwScores.newLine();
        }
        bwScores.flush();
        bwScores.close();
}

But if i input three numbers: 60 Manny, the file would be like this:

   60      Manny
    230     God
    111     Galaxian     
    10      Gorilla
    5       Monkey
    5       Monkey
    5       Monkey

The problem is it can only read 2 numbers because I use sScores.substring(0, 2).trim()). I tried changing it to sScores.substring(0, 3).trim()). but becomes an error because it read upto the character part. Can anyone help me in revising my code so that I can read upto 4 numbers? Your help will be highly appreciated.

jjnguy · Accepted Answer · 2011-02-03 17:32:10Z

3

What you should use is:

String[] parts = sScrores.trim().split("\\s+", 2);

Then you will have an array with the number at index 0, and the name in index 1.

int theNumber = Integer.parseInt(parts[0].trim();
String theName = parts[1].trim();

You could re-write the while-loop like so:

String sScores=brScores.readLine().trim();
while (sScores!=null){
        String[] parts = sScrores.trim().split(" +");
        int theNumber = Integer.parseInt(parts[0].trim();
        if (theNumber < score &&     inserted==false){
                vScores.add(score+"\t"+player+"\t"+rank);
                inserted=true;
        }
        vScores.add(sScores);
        sScores=brScores.readLine();
}

Personally, I would add a new HighScore class to aid in parsing the file.

class HighScore {

    public final int score;
    public final String name;
    private HighScore(int scoreP, int nameP) {
        score = scoreP;
        name = nameP;
    }

    public String toString() {
        return score + "  " + name;
    }

    public static HighScore fromLine(String line) {
        String[] parts = line.split(" +");
        return new HighScore(Integer.parseInt(parts[0].trim()), parts[1].trim());
    }
}

edited Feb 3, 2011 at 17:32

answered Feb 3, 2011 at 17:11

jjnguy

139k54 gold badges298 silver badges328 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

jjczopek Over a year ago

Was writing the same thing :P

newbie Over a year ago

where would i put this code? String theName = parts[1].trim();

jjnguy Over a year ago

@newbie, you don't need that in your code I don't believe. (from what I can see)

newbie Over a year ago

@jjnguy where would i String theName = parts[1].trim(); code so that it would not affect the format of my file?

newbie Over a year ago

@jjinguy THANK YOU VERY MUCH... you are a life saver.. I'll read the link you gave me. Thank you again!

|

JB Nizet · Accepted Answer · 2011-02-03 17:18:41Z

2

The format of each line is always the same : an integer, followed by a tab, followed by the player name.

Just find the index of the the tab character in each line, and substring from 0 (inclusive) to this index (exclusive), before parsing the score.

The player name can be obtained by taking the substring from the tab index +1 (inclusive) up the the length of the line (exclusive).

answered Feb 3, 2011 at 17:18

JB Nizet

694k94 gold badges1.3k silver badges1.3k bronze badges

Comments

Chirag Tayal · Accepted Answer · 2011-02-03 17:22:44Z

1

if above mentioned table is a file.

for first two score it will be fine but for 5 it start reading character. Might be that is causing problem.

answered Feb 3, 2011 at 17:22

Chirag Tayal

4571 gold badge6 silver badges15 bronze badges

Collectives™ on Stack Overflow

Writing a file in Java

3 Answers 3

11 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

11 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related