While Loop in a while loop [Python]

Question

I'm having an issue with my program for some homework I'm working on. I have multiple while loops in my program and it seems that the ones after the first one are causing the first one to just re-print the data I've already had the user input.

repeat = 'y'
p = 'y'
b = 'y'
s = 'y'
while repeat != 'n':
    while p == 'y':
            stocksPurchased = float(input("Number of stocks purchased: "))
            if stocksPurchased < 0:
                print("Negative Values are not allowed. Please re-enter.")
            else:
                    p = 'n'
    while b == 'y':                 
            pricePerStockBought = float(input("Amount per stock purchased in $: "))
            if pricePerStockBought < 0:
                print("Negative Values are not allowed. Please re-enter.")
            else:
                    b = 'n'
    while c == 'y':
            commissionWhole = float(input("Commission Rate as a percent %: "))
            if commissionWhole < 0:
                    print("Negative Values are not allowed. Please re-enter.")
            else:
                    c = 'n'

    while s == 'y':
            pricePerStockSold = float(input("Amount per stock sold in $: "))
            if pricePerStockSold < 0:
                    print("Negative Values are not allowed. Please re-enter.")
            else:
                    s = 'n'
    commissionRate = commissionWhole/100
    grossPurchasePrice = stocksPurchased*pricePerStockBought
    purchaseCommission = grossPurchasePrice*commissionRate
    totalPurchasePrice = grossPurchasePrice+purchaseCommission
    grossSalesPrice = stocksPurchased*pricePerStockSold
    saleCommission = grossSalesPrice*commissionRate
    netSalePrice = grossSalesPrice-saleCommission
    totalCommissionPaid = purchaseCommission+saleCommission
    profit = netSalePrice-totalPurchasePrice
    profitPercentage = (profit/grossPurchasePrice)*100

    print("Commission Fee paid after buying:  $", format(purchaseCommission,  ',.2f'))
    print("Amount stock sold for:             $", format(grossSalesPrice,     ',.2f'))
    print("Commission Fee paid after selling: $", format(saleCommission,      ',.2f'))
    print("Total Commission Paid:             $", format(totalCommissionPaid, ',.2f'))
    print("Total Profit made:                 $", format(profit,              ',.2f'))
    print("Profit Percentage:                 %", format(profitPercentage,    ',.1f'))

    if profitPercentage >= 8:
            print("Congrats! You beat the index fund!")
    elif 0 <= profitPercentage < 8:
            print("Well, you still made money")
    elif profitPercentage == 0:
            print("Nothing gained, nothing lost")
    else:
            print("Perhaps the stock market isn't for you")

                if totalCommissionPaid > profit:
                    print("Seems you should either pick different stocks, or find a cheaper broker")

    repeat = input("Would you like to go again y/n?: ")

If I enter y here the program repeats but instead of re-prompting for the numbers it just re-prints the data from the previous run.

For example if I enter in the numbers: 1000, 10, 5, 15 respectively it will just reprint the same numbers from before.

Example of the issue I am having

Looks like you need to reset p, b, s to 'y' each time the outer loop repeats. — eugenhu
– eugenhu, Commented Apr 2, 2018 at 3:47
No problems, please try to reduce your sample code as much as possible next time (see mcve). This can help with debugging and the mistake would have been a lot clearer, it's likely you would have even picked it up before having to post the question. — eugenhu
– eugenhu, Commented Apr 2, 2018 at 3:53

Arjun Kay · Accepted Answer · 2018-04-02 03:50:02Z

2

Set the values of p, b, c and s to 'y'.

answered Apr 2, 2018 at 3:50

Arjun Kay

3281 silver badge13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

lyxal · Accepted Answer · 2018-04-02 03:49:51Z

0

The fix to this problem is easy: reset the values of p, b, s, and c at the beginning of the first while loop:

repeat = 'y'
while repeat != 'n':
    p = 'y'
    b = 'y'
    s = 'y'
    c = 'y'

    #Rest of code here

answered Apr 2, 2018 at 3:49

lyxal

1,1182 gold badges18 silver badges29 bronze badges

Comments

Stoicas · Accepted Answer · 2018-04-02 03:50:02Z

0

You need to initialize your variables within the while loop in order to fix this problem. This way, whenever you are done with iteration of the loop your variables will be restarted, so the condition for the next loops is satisfied. So your code should be:

while repeat != 'n':
    repeat = 'y'
    p = 'y'
    b = 'y'
    s = 'y'
    c ='y'
    while p == 'y':
        stocksPurchased=float(input("Number of stocks purchased: "))
        if stocksPurchased < 0:
            print("Negative Values are not allowed. Please re-enter.")
        else:
            p = 'n'

On top of that you should fix your indentation since it seems a little bit off.

answered Apr 2, 2018 at 3:50

Stoicas

1014 bronze badges

Comments

Mushif Ali Nawaz · Accepted Answer · 2018-04-02 03:51:28Z

0

You need to write these lines:

p = 'y'
b = 'y'
s = 'y'

inside the main while loop. Then it will solve your problem.

answered Apr 2, 2018 at 3:51

Mushif Ali Nawaz

3,9163 gold badges21 silver badges33 bronze badges

Comments

veronik · Accepted Answer · 2018-04-02 03:56:22Z

0

You need to reset the conditionals inside the first while loop.

That is put

p = 'y'
b = 'y'
s = 'y'

After your last line

answered Apr 2, 2018 at 3:56

veronik

1772 silver badges11 bronze badges

Comments

Pabasara Ranathunga · Accepted Answer · 2018-04-02 04:04:50Z

0

The problem is with your variables. After the first loop your variables p, b, c and s are assigned with 'n'. So the second loop take them as n no y You can try something like,

repeat = p = b = c = s = input("Would you like to go again y/n?: ").

There can be better methods. But the problem was with your variable values after the first loop.

answered Apr 2, 2018 at 4:04

Pabasara Ranathunga

1701 gold badge2 silver badges18 bronze badges

Collectives™ on Stack Overflow

While Loop in a while loop [Python]

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related