Finding common strings in javascript

Question

I am trying to find common strings in given two strings.

Example:

string1 = "mega,cloud,two,website,final"
string2 = "window,penguin,literature,network,fun,cloud,final,sausage"
answer = "cloud,final,two"

So far this is what i got:

function commonWords(first, second) {
    var words = first.match(/\w+/g);
    var result = "";
    words.sort();
    for(var i = 0; i < words.length; i++){
        if(second.includes(words[i])){
            result = result.concat(words[i]);
            result += ",";
        }
    }
    result = result.substr(0, result.length -1);
    return result;

}

But the result that i got is :

answer = cloud,final

Can you help me out please? First time asking question on StackOverFlow, so sorry for the typing.

Where is two coming from? Did you forget to add it in the second string in the example? — Get Off My Lawn
– Get Off My Lawn, Commented Jun 2, 2018 at 17:08
If you want to find the two string from network then you can't use the w+ which define word boundaries ! — Martin
– Martin, Commented Jun 2, 2018 at 17:11
Okey i believe two comes from "network", which it shouldn't. I should use something different than 'includes'. — Mücahid Erenler
– Mücahid Erenler, Commented Jun 2, 2018 at 17:12

Get Off My Lawn · Accepted Answer · 2018-06-02 17:14:08Z

1

What I would do is first split on the two strings, then do a reduce and check if the other string includes the current string. If so add them to a new array.

const string1 = "mega,cloud,two,website,final"
const string2 = "window,penguin,literature,network,fun,cloud,final,sausage"

const array1 = string1.split(',')
const array2 = string2.split(',')

const result = array1.reduce((arr, val) => array2.includes(val) ? arr.concat(val) : arr, [])

console.log(result)
// Convert it to a string if desired
console.log(result.toString())

answered Jun 2, 2018 at 17:14

Get Off My Lawn

36.6k47 gold badges201 silver badges380 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

amrender singh · Accepted Answer · 2018-06-02 17:19:03Z

0

Try the following:

string1 = "mega,cloud,two,website,final"
string2 = "window,penguin,literature,network,fun,cloud,final,sausage";
var arr1= string1.split(",");
var arr2 = string2.split(",");

var result = [];
arr1.forEach(function(str){
 arr2.forEach(function(str2){
    if(str2.indexOf(str) != -1)
      result.push(str);
 });
});
var answer = result.join(",");
console.log(answer);

answered Jun 2, 2018 at 17:19

amrender singh

8,2594 gold badges27 silver badges30 bronze badges

Comments

Mudit · Accepted Answer · 2018-06-02 17:26:15Z

The problem with your function is you also converting the string to into second as an array.

function commonWords(first, second) {
    var words = first.match(/\w+/g); // word is a array type
    var result = ""; 
    words.sort();
    for(var i = 0; i < words.length; i++){
        if(second.includes(words[i])){ //second should be string type
            result = result.concat(words[i]);
            result += ",";
        }
    }
    result = result.substr(0, result.length -1);
    return result;

}

Or you can try this

    first = "mega,cloud,two,website,final"
second = "window,penguin,literature,network,fun,cloud,final,sausage"

function commonWords(first, second) {
    var words = first.match(/\w+/g);
    var result = "";
    words.sort();
    for(var i = 0; i < words.length; i++){
        if(second.includes(words[i])){
            result = result.concat(words[i]);
            result += ",";
        }
    }
    result = result.substr(0, result.length -1);
    return result;

}

console.log(commonWords(first, second));

Ivan · Accepted Answer · 2018-06-02 17:26:19Z

0

I would convert each string to an array of words with .split(','). Then filter the first array with .filter by checking if each item of the array is in the other one:

string1 = "mega,Cloud,two,website,final"
string2 = "window,penguin,literature,network,fun,cloud,final,sausage"

array1 = string1.toLowerCase().split(',')
array2 = string2.toLowerCase().split(',')
var a = array1.filter(word => -1 !== array2.indexOf(word));

console.log(a)

Before converting the string to an array I have applied .toLowerCase() so that the script can return cloud in the result if it appears in the first one as "Cloud" and in the second as "cloud"

edited Jun 2, 2018 at 17:26

answered Jun 2, 2018 at 17:15

Ivan

41.3k9 gold badges78 silver badges120 bronze badges

1 Comment

charlietfl Over a year ago

might want to do some trimming since you introduced extra spaces

Collectives™ on Stack Overflow

Finding common strings in javascript

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related