For Loop in C# not looping

Question

I have an issue with a Loop that doesn't actually loop. I've posted a simplified version of my code below. Basically, using the NPOI excel library, I have an excel file with data on the first and second sheet, so I need to do a loop to get through both sheets.

Below is what I have done so far, however this only works through the first sheet and then exits. It fails to increment the variable w. As you can see, there are other loops implemented in this code which function fine so I don't get it.

It's been a very long day and perhaps I'm missing something very simple. I could have it placed wrong or something. If anyone else can spot what I might be doing wrong I'd be very grateful :)

public class SalesFileProcessor : ISalesProcessor
    {
        public List<FTPSalesRow> ProcessSalesFile(string filename)
        {
            try
            {

            using (FileStream fs = File.Open(filename, FileMode.Open, FileAccess.Read))
            {
                int numberOfSheets = 2;
//Loop through sheets - does not work
                for (int w = 0; w <= numberOfSheets; w++)
                {
                    HSSFWorkbook templateWorkbook = new HSSFWorkbook(fs);

                    HSSFSheet sheet = templateWorkbook.GetSheetAt(w);
                    HSSFRow row = null;


                    for (int i = 1; i <= sheet.LastRowNum; i++)
                    {
                        FTPSalesDetails t = null;
                        int currentColumn = 0;

                        try
                        {
                            ModelContainer ctn = new ModelContainer();

                            row = sheet.GetRow(i);

                            if (row == null)
                            {
                                continue;
                            }

                            t = new FTPSalesDetails
                            {
                                RowNumber = i,
                                InvoiceDate = GetCellValue(row.GetCell(0)),
                                CountrySoldIn = GetCellValue(row.GetCell(1)),
                                NetUnitsSold = GetCellValue(row.GetCell(2)),
                                Item = GetCellValue(row.GetCell(3)),
                                ProductCode = GetCellValue(row.GetCell(5)),
                            };

                            if (t.ProductCode == null && t.NetUnitsSold == null)
                            {
                                return null;
                            }

                            int Qty = int.Parse(t.NetUnitsSold);


                            for (int x = 0; x < Qty; x++)
                            {
                                ItemSale ts = new ItemSale
                                {
                                    ItemID = GetItemID(t.ProductCode),
                                    ManufacturerID = GetManufacturerID("Samsung"),
                                    DateSold = DateTime.Now,
                                };

                                ctn.AddToItemSales(ts);
                                ctn.SaveChanges();
                            }
                        }
                        catch (IndexOutOfRangeException) { }
                    }
                } //End Loop - the one that doesn't work
            }
        }
        catch (IOException exp)
        {
            throw new FTPSalesFileProcessingException("Could not open the Sales data file", exp);
        }
        catch (Exception exp)
        {
            throw new FTPSalesFileProcessingException("An unknown eror occured during processing the file", exp);
        }

        return null;
    }

@Armen, I certainly did. numberOfSheets is as you'd expect, w seems to stay at zero, while i works as it should. — 109221793
– 109221793, Commented Feb 23, 2011 at 16:03
Did you step through this code to verify all the values are getting set as you expect? — SuperNES
– SuperNES, Commented Feb 23, 2011 at 16:17

msarchet · Accepted Answer · 2011-02-23 16:10:24Z

4

 if (t.ProductCode == null && t.NetUnitsSold == null)
  {
      return null;
  }

I'm going to guess that this is being hit, causing your entire function to exit. If you are trying to exit out of that iteration of the for loop try a break; instead, or a continue as Mike M pointed out in the comments.

edited Feb 23, 2011 at 16:10

answered Feb 23, 2011 at 16:04

msarchet

15.3k2 gold badges45 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

109221793 Over a year ago

you're right, that is exactly what's happening. I'll have to rethink it. Ideally "for (int i = 1; i <= sheet.LastRowNum; i++)" should take care of things, but for some reason, my excel sheet in questions shows that it has 388 rows, however only two are shown in the actual sheet, which is why I implemented that if. Thanks for spotting that. Will mark as correct when the time limit is up.

Mike M. Over a year ago

I'm going to also guess that if the current row is null, he might just want to continue onto the next row, not necessarily move to the next sheet. In which case you should use continue; not break;. Of course, we're both just guessing :)

msarchet Over a year ago

@Mike M, yes perhaps I think he's got it figured out now.

Jorge Córdoba · Accepted Answer · 2011-02-23 16:06:25Z

1

For what you say, assuming your variables are all ok that is the loop is not empty... have you checked you're not hiting this line in the first iteration?

if (t.ProductCode == null && t.NetUnitsSold == null)
                            {
                                return null;
                            }

answered Feb 23, 2011 at 16:06

Jorge Córdoba

52.4k11 gold badges83 silver badges130 bronze badges

Comments

Joel Etherton · Accepted Answer · 2011-02-23 16:04:26Z

0

Looking at the code, the only obvious thing sticking out to me is:

HSSFSheet sheet = templateWorkbook.GetSheetAt(w);
HSSFRow row = null;

for (int i = 1; i <= sheet.LastRowNum; i++)

I would guess that sheet.LastRowNum either equals 0 or 1.

answered Feb 23, 2011 at 16:04

Joel Etherton

37.5k10 gold badges92 silver badges106 bronze badges

Comments

Carlos Valenzuela · Accepted Answer · 2011-02-23 16:07:38Z

0

Maybe the indexOutOfRangeException is thrown and thats beacuse you have only one iteration, or instead of <= you sholud use <. Does the sheet numbers start with zero ?

answered Feb 23, 2011 at 16:07

Carlos Valenzuela

8341 gold badge7 silver badges19 bronze badges

Collectives™ on Stack Overflow

For Loop in C# not looping

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related