For loop does not functioning as expected in C#

Question

I have an excel with 10 columns, I need to validate the values in each column of this excel separately and that is why I am looping through each column one by one.

Now the validation for each column is different.For some columns I need to compare the values in the columns with the values in certain lists.

These Lists say: List1 List2 List3...

Contain the Valid values.The values entered in the columns should be a part of these lists. So, say the first column should contain only the values that are a part of list 1.

What could be the most efficient way to do this? colcount here is 10, rowcount is 5.

for (int c = 1; c <= colcount; c++)
{
    for (int r = 2; r <= rowcount; r++) 
    {
        string celldata = usedRange.Cells[r,c].Text;
        if (c == 1)
        {
            if (List1.Contains(celldata))
            {
                return true;
            }
            else
            {
                return false;
            }
        }
        else if (c == 2)
        {
            if (List2.Contains(celldata))
            {
                return true;
            }
            else
            {
                return false;
            }
        }
        else if (c == 3)
        {
            if (List3.Length <=10 && regex.IsMatch(celldata))
            {
                return true;
            }
            else
            {
                return false;
            }
        }
    }
}

Can't figure out if I am making some basic mistake.

return will exit the entire function.What are you trying to accomplish by returning true and false? — DetectivePikachu
– DetectivePikachu, Commented Sep 10, 2019 at 16:56
In addition to what @DetectivePikachu said, your for loop smells of bad design. Once inside the inner loop you already know the value of c, so I think this could be restructured better. — Sach
– Sach, Commented Sep 10, 2019 at 16:59
Please edit your question to explain what you want your code to do, and what the structure of your objects are, to the extent that one can reproduce the situation. — Heretic Monkey
– Heretic Monkey, Commented Sep 10, 2019 at 17:08
Hi, @HereticMonkey I have edited the question. I hope this is fine — Learner.123
– Learner.123, Commented Sep 11, 2019 at 7:17
Hi @Sach I am new to this, if you could please tell me how can I make this efficient — Learner.123
– Learner.123, Commented Sep 11, 2019 at 7:18

Eric · Accepted Answer · 2019-09-10 17:11:15Z

1

If you want to get out of the inner loop use break.

The break statement terminates the closest enclosing loop or switch statement in which it appears. Control is passed to the statement that follows the terminated statement, if any.

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/break

answered Sep 10, 2019 at 17:11

Eric

1461 silver badge10 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

For loop does not functioning as expected in C#

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related