problem using pointer array?

Question

code:

char *m[10];
char * s;

int lcounter=0;
int sd=0;
char mem_buf [ 500 ];
while ( fgets ( mem_buf, sizeof mem_buf, infile ) != NULL )
{

    m[lcounter] =(char *) malloc(10*sizeof(char));

    item = strtok(mem_buf,delims);
    m[lcounter]=item;
    printf("\n value inside==== :%s:",m[lcounter]);
    lcounter=lcounter+1;

}

for(i=0;i<lcounter;i++)
{
    printf("\n value outside==== :%s:",m[sd]);
    sd++;
}

input:

goo|
bbb|
ccc|

When I execute this am getting below output:

value inside==== : goo
value inside==== : bbb
value inside==== : ccc

value outside====:ccc
value outside====:ccc
value outside====:ccc

But I need like:

value outside====:goo
value outside====:bbb
value outside====:ccc

@stefan Your comment doesn't make any sense. The culprit is m[lcounter]=item. — chrisaycock
– chrisaycock, Commented Feb 26, 2011 at 7:50
@chrisaycock: You are right :) I will remove it, i missed the strtok ;) — stefan
– stefan, Commented Feb 26, 2011 at 7:52

Karl Bielefeldt · Accepted Answer · 2011-02-26 07:47:03Z

1

Use strcpy if you want it to last outside of the loop. strtok may reuse the same pointer.

answered Feb 26, 2011 at 7:47

Karl Bielefeldt

49.5k10 gold badges62 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jcrshankar Over a year ago

ya i did small change that u suggest, i got it. thanks a lot.

chrisaycock · Accepted Answer · 2011-02-26 07:51:56Z

1

This won't copy a C string:

m[lcounter]=item;

Instead, use:

strcpy(m[lcounter], item);

answered Feb 26, 2011 at 7:51

chrisaycock

38.1k15 gold badges94 silver badges128 bronze badges

Collectives™ on Stack Overflow

problem using pointer array?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related