use error middleware when using express.Router

Question

I want to use express.Router in my app. I have a file index file that runs the server. And a file routes that run some express routes, thanks to express.Router.

What I want that, whenever one of my route fails, the error middleware defined in index is reached;

In the example above: - when I use the route ok, it works - when I use the route no ok, the error is thrown without reaching the error middleware.

Do you know how to achieve it ?

Thank you !

https://gist.github.com/VivienAdnot/e3cf44de745531c6cca7be5de53c341a

Possible duplicate of Node.js (Express) error handling middleware with router — Prashant Tapase
– Prashant Tapase, Commented Jul 31, 2018 at 12:32

Narendra Kamath · Accepted Answer · 2018-07-31 12:29:17Z

1

Looking at your code, I can see that you are missing the 'next' argument in the error-handler middleware, since 'next' is required to pass the control to the next matching route. Just change the middleware code in index.js to,

app.use((err, req, res, next) => {
    console.log('error mw reached');
    res.status(500);
    res.end();
    next();
});

and it works.

edited Jul 31, 2018 at 12:29

answered Jul 31, 2018 at 12:24

Narendra Kamath

591 silver badge6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vivien Adnot · Accepted Answer · 2018-07-31 12:21:22Z

0

My error middleware was bad-named ...

// doesn't work
app.use((err, req, res) => {
    console.log('error mw reached');
    res.status(500);
    res.end();
});

to:

//works
app.use((err, req, res, next) => {
    console.log('error mw reached');
    res.status(500);
    res.end();
});

answered Jul 31, 2018 at 12:21

Vivien Adnot

1,2874 gold badges17 silver badges33 bronze badges

Collectives™ on Stack Overflow

use error middleware when using express.Router

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related