php not echoing error message if data is missing - instead displaying php fatal error

Question

I am using PHPMailer in order to build a contact form and I am looking for a variable ($msg) to display a success or failure message depending on if the end user has correctly filled out the form or not. The ($msg) variable echo's succesfully if the form is completed correctly however, the $(msg) variable does not echo if the user does not fill out the form correctly and instead I receive a fatal error which reads as follows:

Fatal error: Uncaught PHPMailer\PHPMailer\Exception: Invalid address: (Reply-To): in /home/k4piavsj0bsc/public_html/phpmailer/src/PHPMailer.php:1004 Stack trace: #0 /home/k4piavsj0bsc/public_html/phpmailer/src/PHPMailer.php(973): PHPMailer\PHPMailer\PHPMailer->addOrEnqueueAnAddress('Reply-To', '', '') #1 /home/k4piavsj0bsc/public_html/contactForm.php(18): PHPMailer\PHPMailer\PHPMailer->addReplyTo('') #2 /home/k4piavsj0bsc/public_html/contactForm.php(30): sendemail('info@purplelime...', '', '', '') #3 /home/k4piavsj0bsc/public_html/index.php(9): include('/home/k4piavsj0...') #4 {main} thrown in /home/k4piavsj0bsc/public_html/phpmailer/src/PHPMailer.php on line 1004

Here's my code, does anyone have any ideas how I get the ($msg) variable to display if the end user has not completed the form or it has failed from the server side?

<?php

use PHPMailer\PHPMailer\PHPMailer;
use PHPMailer\PHPMailer\Exception;

$msg = "";

if (isset($_POST['submit'])) {
    require 'phpmailer/src/Exception.php';
    require 'phpmailer/src/PHPMailer.php';
    require 'phpmailer/src/SMTP.php';

    function sendemail ($to, $reply, $subject, $body) {
        $mail = new PHPMailer(true);
        $mail->setFrom('[email protected]', 'PLT Contact Form - Email');
        $mail->addAddress($to);
        $mail->addReplyTo($reply);
        $mail->Subject = $subject;
        $mail->Body = $body;
        $mail->IsHTML(false);

        return $mail->send();
    }

    $email = $_POST['email'];
    $subject = $_POST['subject'];
    $body = $_POST['body'];

    if (sendemail('[email protected]', $email, $subject, $body)) {
        $msg = 'Email has been sent, Thank you!';
    } else
        $msg = 'Email failed, please try again later';

  }

?>


<html>

<title>Contact Form Using PHPMailer</title>


<body>

    <div id="contactInnerWrapper">
        <a href="#"><span id="close">&times;</span></a>
        <h1 id="h1contactForm">Get in touch</h1>
            <form method="post" action="contactForm.php">
                <label for="email">Email address:</label><br>
                <input  type="email" name="email"  placeholder="Enter email" id="email">
                <label for="subject">Subject:</label>
                <input  type="text" name="subject" id="subject"><br>
                <label for="body">What would you like to ask us?</label><br>
                <textarea  type="text" name="body" rows="7" id="content"></textarea>
                <button type="submit" name="submit" id="submit" value="send">Submit</button>
            </form>
            <br><br>
            <?php echo $msg; ?>
    </div>

    <script type="text/javascript" src="general.js"></script>

 </body>

</html>

Do your question (in bold font) does have anything in common with that error above? I would say “Invalid address” is a clear enough – pass a valid email address into $_POST['email'] and you will see a result. Would be be better though, to check if the given email address is a valid one — feeela
– feeela, Commented Aug 2, 2018 at 7:45
Adding some data validation might do the trick. Never assume that you get all the data you need in the format you expect from the user. Rule of thumb, never trust user data. — M. Eriksson
– M. Eriksson, Commented Aug 2, 2018 at 7:49
Also surround the call to sendemail with try, catch PHPMailer\PHPMailer\Exception and set the error message on the catch clause — Theofanis
– Theofanis, Commented Aug 2, 2018 at 7:51
Use Try catch for better error handling : try { // your code } catch (Exception $e) { echo 'Message could not be sent. Mailer Error: ', $mail->ErrorInfo; } — prakash tank
– prakash tank, Commented Aug 2, 2018 at 7:53
Thanks for all the feedback, I'm very new to PHP so all the suggestions you are providing are very much appreciated but unfortunately I am unable to understand some of the terminologies you are referring to. Could I ask that some code is provided so that I can see where I am going wrong and can try and get it to work :) — Coder
– Coder, Commented Aug 2, 2018 at 7:56

Theofanis · Accepted Answer · 2018-08-02 09:14:41Z

1

Change the last if statement to this

$email = filter_var($email, FILTER_SANITIZE_EMAIL); // 
if (filter_var($email, FILTER_VALIDATE_EMAIL) && !empty($subject) && !empty($body)) {
    try {
        if (sendemail('[email protected]', $email, $subject, $body))
            $msg = 'Email has been sent, Thank you!';
        else
            $msg = 'Error sending email';
    }catch(Excpetion $e) {
        $msg = 'Sending email failed, error: '.$e->getMessage();
    }
} else
    $msg = 'Email failed, incomplete/invalid data';

Remove all illegal characters from email with FILTER_SANITIZE_EMAIL.
The FILTER_VALIDATE_EMAIL filter validates an e-mail address.
Check if not empty body and subject.
Try sending the email and on fatal error properly catch it and return an explanatory message.
If sendemail function return correctly set success message or else set error message.

edited Aug 2, 2018 at 9:14

answered Aug 2, 2018 at 7:58

Theofanis

6376 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

17 Comments

user8034901 Over a year ago

A little info on what you changed and why you changed it could be helpful for OP

Coder Over a year ago

when I run the code and submit the form as incomplete the page just goes blank with no error messages and nothing showing in the console?

Theofanis Over a year ago

@Coder In my code I set the error message, do you print the message at any point? I don't see an echo statement at the original part of your code you provided.

Coder Over a year ago

I echo it on the html file, I will upload html code now for you to see. Hopefully you can help!

Theofanis Over a year ago

@Coder yeah sorry my mistake, forgot '$' signs, update the if statement with this if (filter_var($email, FILTER_VALIDATE_EMAIL) && !empty($subject) && !empty($body)) { added '$' sign before 'subject' and 'body' here

|

Ahmed Numaan · Accepted Answer · 2018-08-02 08:00:52Z

0

I think the following code will help you understand and solve your problem.

$email = isset($_POST['email']) ? $_POST['email']:'';
$subject = isset($_POST['subject']) ? $_POST['subject']:'';
$body = isset($_POST['body']) ? $_POST['body']:'';

$is_valid_email = filter_var($email, FILTER_VALIDATE_EMAIL);

$status = false;
if ($email!='' && $is_valid_email==true && $subject!='' && $body!='') {
    $status = sendemail('[email protected]', $email, $subject, $body)
}
if($status==true){
    $msg = 'Email has been sent, Thank you!';
} else
    $msg = 'Email failed, please try again later';
}

edited Aug 2, 2018 at 8:00

answered Aug 2, 2018 at 7:50

Ahmed Numaan

1,0601 gold badge10 silver badges26 bronze badges

2 Comments

M. Eriksson Over a year ago

This only checks if email has a value, not that it contains a valid email address. Also, in PHP7+, you can use the short hand $email = $_POST['email'] ?? null; instead.

Ahmed Numaan Over a year ago

Email validation added before calling sendemail() function.

vicky sawant · Accepted Answer · 2023-05-16 16:24:43Z

0

You have to change config php.ini file in your php handling module setting

1.go to your module (Like xampp apache ).

2.open config file

3.search for error_reporting (Here you will see the error what type of error reporting your module is giving for php program test.)

4.error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT & ~E_WARNING set error reporting like this;

By doing that you are get all error but not warning and fetal error

edited May 16, 2023 at 16:24

answered May 16, 2023 at 16:23

vicky sawant

11 bronze badge

Collectives™ on Stack Overflow

php not echoing error message if data is missing - instead displaying php fatal error

3 Answers 3

17 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

17 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related