C# Lambda Expression To Replace String Values In String Array

Question

I am trying to use .net 4.0 lambda methodology to remove double quotes (") around items in an array. Here is the code I have, however, this does not seem to work.

What am I doing wrong?

string[] sa = new string[] { "\"Hello\"", "\"Goodbye\"", "\"Moshi\"", "\"Adios\"" };

// Trying to replace the 
Array.ForEach(sa, s => s.Replace("\"", "")); // Doesn't remove the quotes surrounding the string "Hello".
foreach(var s in sa)
   Console.WriteLine(s);

This still does not get rid of the " around the items.

Sergey Kalinichenko · Accepted Answer · 2018-08-16 03:04:19Z

11

There is no lambda expression that could be plugged into ForEach to accomplish your goal, because the action a lambda could take has no write access to the element, and the string itself is immutable.

What you can do is replacing the whole array, like this:

sa = sa.Select(s => s.Replace("\"", "")).ToArray();

This approach works, because it replaces the entire sa array with a newly created array that is based on sa's elements.

answered Aug 16, 2018 at 3:04

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nhan Phan · Accepted Answer · 2018-08-16 06:59:15Z

1

You can use Linq:

sa = sa.Select(s => s.Replace("\"", "")).ToArray();

OR use for loop:

for (var i = 0; i < sa.Length; i++)
    {
        sa[i] = sa[i].Replace("\"", "");
    }

edited Aug 16, 2018 at 6:59

answered Aug 16, 2018 at 3:34

Nhan Phan

1,3021 gold badge15 silver badges35 bronze badges

Comments

EdSF · Accepted Answer · 2018-08-16 05:43:15Z

-1

The other answers are what you should do if you want a new array out of some processing you perform on it's items.

However, if you don't (need a new array), and want to perform an Action on each item of the array (which is what Array.ForEach does), you could do:

//This is pretty much what your code is trying to do
Array.ForEach(sa, i => Console.WriteLine(i.Replace("\"", "")));

answered Aug 16, 2018 at 5:43

EdSF

12.5k6 gold badges45 silver badges85 bronze badges

Collectives™ on Stack Overflow

C# Lambda Expression To Replace String Values In String Array

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related