PHP - accessing global variables in all functions of class [duplicate]

Question

I need to access some variables of an external php file in most of functions of a class. I'm accessing in following way (and it works fine)

class test{

function a(){ 
    global $myglobalvar ;
    ..
    ..
    }

function b(){ 
    global $myglobalvar ;
    ..
    ..
    }

function c(){ 
    global $myglobalvar ;
    ..
    ..
    }

}

Is there a way that i can access $myglobalvar in all functions of the class without declaring in each function? I did read that it can be done by declaring only once in the constructor of the class, but I dont know how to do it. Thanks for any help.

That's PHP's way of telling you "stop this shit, you're doing it wrong(tm)". And mind you, PHP isn't one of those languages fanatic about good code. — user395760
– user395760, Commented Mar 6, 2011 at 18:41

Super Cat · Accepted Answer · 2014-12-24 20:52:42Z

14

class test{

 private $myglobalvar;

 public function __construct($var){
  $this->myglobalvar = $var;
 }

 function a(){ 
  echo $this->myglobalvar;
 }

 function b(){ 
  echo $this->myglobalvar; 
 }

 function c(){ 
  echo $this->myglobalvar;
 }

}

$test = new test("something");
$test->a(); // echos something
$test->b(); // echos something
$test->c(); // echos something

edited Dec 24, 2014 at 20:52

Super Cat

1,6871 gold badge19 silver badges25 bronze badges

answered Mar 6, 2011 at 18:39

Prisoner

27.7k11 gold badges78 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

RDL Over a year ago

You are missing the global declaration

Mark Fox Over a year ago

@RDL the whole point of this design is that the global is passed via the constructor so that the object's scope is properly insulated and isn't dependent on a specific naming of an external resource. Promotes reuse.

mario · Accepted Answer · 2011-03-06 18:41:13Z

5

You can create a reference to a global variable in the constructor (much like global would):

class test{

    function __construct() { 
        $this->myglobalvar = & $GLOBALS["myglobalvar"];

Which then allows aceess to the global via $this->myglobalvar in each method.

answered Mar 6, 2011 at 18:41

mario

146k20 gold badges243 silver badges293 bronze badges

1 Comment

Gordon Over a year ago

Sure that would work, but why teach people code smells like that?

markus · Accepted Answer · 2011-03-06 19:37:36Z

2

If you tell us more about this case, we might be able to tell you a better way to solve your problem. Globals should be avoided, whenever possible. Are you really talking about a variable or is it more like a configuration option that stays the same during a whole server roundtrip. In that case you could think of treating it like a configuration option and store it in a registry object (singleton).

answered Mar 6, 2011 at 19:37

markus

40.8k23 gold badges100 silver badges143 bronze badges

Collectives™ on Stack Overflow

PHP - accessing global variables in all functions of class [duplicate]

3 Answers 3

2 Comments

1 Comment

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Linked

Related