PHP inline if statement always returns false

Question

can't seem to start this working properly, any idea what could be the problem? The variable APP_NAME is equal to string 'test', if I do this if statement in a regular way it works as it should.

<?=form_radio('filter', 'y', $info['enable_categories'] == 'y' ? true : false, 'id="app" '.APP_NAME == "test" ? '' : 'disabled'.'')?>

The disabled parameter has to be put into the same last parameter as id.

But this way I get the false value even if APP_NAME equals 'test'.

The function form_radio has these parameters:

function form_radio($data = '', $value = '', $checked = FALSE, $extra = '') so the extra parameter has to be ID and also the "disabled" string if the value is not equal to 'test'.

you pass this: $info['enable_categories'] == 'y' ? true : false, 'id="app" '.APP_NAME == "test" ? '' : 'disabled'.'' as parameters? — law_81
– law_81, Commented Sep 3, 2018 at 7:01

Karsten Koop · Accepted Answer · 2018-09-03 07:02:42Z

4

When you write

'id="app" '.APP_NAME == "test" ? '' : 'disabled'.''

the operator precedence makes this evaluate as

('id="app" '.APP_NAME) == "test" ? '' : 'disabled'.''

So you should use parentheses around the ternary clause:

'id="app" '.(APP_NAME == "test" ? '' : 'disabled'.'')

You can also get rid of the .''. Also the clause

$info['enable_categories'] == 'y' ? true : false

can be simplified to

$info['enable_categories'] == 'y'

answered Sep 3, 2018 at 7:02

Karsten Koop

2,5241 gold badge20 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

The50 Over a year ago

Thank you so much for the explanation. :)

Collectives™ on Stack Overflow

PHP inline if statement always returns false

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related