How to pass string in the url as a parameter in asp.net core api controller

Question

I am trying to build an api that takes an IForm file from the body and then save the file. Then return the filename in the response. I achieved the same before. But then I had an integer value as the parameter, this case it is a string. I am trying this way. But when the route matches it always returning status 200 without saving the file and filename in the response.

[HttpPost]
[Route("/api/users/${email}/photos")]
public async Task<IActionResult> Upload(string email, [FromBody]IFormFile fileStream)
{
    var user = this.repository.GetUserByEmail(email);
    if (user == null)
        return NotFound();
    var uploadsFolderPath = Path.Combine(host.WebRootPath, "Images");
    if (!Directory.Exists(uploadsFolderPath))
        Directory.CreateDirectory(uploadsFolderPath);

    if (fileStream == null) return BadRequest("null file");
    if (fileStream.Length == 0) return BadRequest("Empty file");
    if (fileStream.Length >= photoSettings.MaxBytes) return BadRequest("Max file size exceeded");
    if (!photoSettings.IsSupported(fileStream.FileName)) return BadRequest("Invalid file type");

    var fileName = Guid.NewGuid().ToString() + Path.GetExtension(fileStream.FileName);
    var filePath = Path.Combine(uploadsFolderPath, fileName);
    using (var stream = new FileStream(filePath, FileMode.Create))
    {
        await fileStream.CopyToAsync(stream);
    }
    user.ImageUrl = fileName;
    await unitOfWork.CompleteAsync();
    return Ok(fileName);
}

Though the response is 200. it is not even showing any bad request when it should be invalid filetype.

[Route("/api/users/${email}/photos")] should be [Route("/api/users/{email}/photos")] (no $) and [FromBody] should be removed. — Kirk Larkin
– Kirk Larkin, Commented Sep 6, 2018 at 13:50
It doesn't look like your Upload action is being called at all - The screenshot suggests it's your home page that's being generated. You'll need to URL-encode that @ too (shamimvai%40gmail.com without the 's). — Kirk Larkin
– Kirk Larkin, Commented Sep 6, 2018 at 13:52
Thanks now the upload method is called but now it is showing null file. while I am sending a photo in the body — Exception handler
– Exception handler, Commented Sep 6, 2018 at 14:09
Likely the developer exception page, actually, meaning there's an uncaught exception. — Chris Pratt
– Chris Pratt, Commented Sep 6, 2018 at 14:09

Todd Skelton · Accepted Answer · 2018-09-07 03:42:10Z

3

It looks like you figured it out, but just to answer the question you need to remove the $ and you can specify that the email parameter is from the route using the attribute [FromRoute] but it may not be required.

[HttpPost]
[Route("/api/users/{email}/photos")]
public async Task<IActionResult> Upload([FromRoute]string email, [FromBody]IFormFile fileStream)
{
    //..
}

answered Sep 7, 2018 at 3:42

Todd Skelton

7,2873 gold badges39 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to pass string in the url as a parameter in asp.net core api controller

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related