regex javascript- error

Question

Why isn't this regular expression working? A correct email address does not pass the validation.

<script type="text/javascript">
$(document).ready(function() {

    var regex = new RegExp(/^([\w-]+(?:\.[\w-]+)*)@((?:[\w-]+\.)*\w[\w-]{0,66})\.([a-z]{2,6}(?:\.[a-z]{2})?)$/i );

    $('#submit').click(function () {    
        var name = $('input[name=name]');
        var email = $('input[name=email]');
        var website = $('input[name=website]');
        var comment = $('textarea[name=comment]'); 
        if ((!regex.test(email))) {
            email.addClass('hightlight');
            return false;
        } else 
            email.removeClass('hightlight');            
    }
}
}

link: http://emprego.herobo.com/

The regex is working, the problem is in your code. I don't know much about JavaScript, but at first glance what I see is an extra } flying by there. — sidyll
– sidyll, Commented Mar 15, 2011 at 2:26
the reason is that i edit my code (it is bigger), and possibility have more }, my mistake, but the problem is other, thanks — daniel__
– daniel__, Commented Mar 15, 2011 at 2:27
Maybe you need to change !regex.test(email) to !regex.test(email.value) or something? Rough guess. If it is correct I'll post as answer — sidyll
– sidyll, Commented Mar 15, 2011 at 2:34
It'd be great if you can provide the email address that isn't being validated. We can't see yours. — Jon
– Jon, Commented Mar 15, 2011 at 2:34

Bryan · Accepted Answer · 2011-03-15 02:36:32Z

5

You are calling the RegExp test method on a jQuery object instead of a string. Change your conditional from:

if ((!regex.test(email))) { ... }

to:

if ((!regex.test(email.val()))) { ... }

and it should work.

answered Mar 15, 2011 at 2:36

Bryan

2,85525 gold badges39 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sean Adkinson · Accepted Answer · 2011-03-15 02:31:38Z

1

For what email address are they failing? This regex appears to work:

var regex = new RegExp(/^([\w-]+(?:\.[\w-]+)*)@((?:[\w-]+\.)*\w[\w-]{0,66})\.([a-z]{2,6}(?:\.[a-z]{2})?)$/i );

var emails = [
    '[email protected]',
    '[email protected]',
    '[email protected]'
];

var str = '';
for (var i=0; i<emails.length; i++) {
    str += emails[i] + ': ' + regex.test(emails[i]) + "\n";
}
alert(str);

This produces an alert with "true" for each email.

answered Mar 15, 2011 at 2:31

Sean Adkinson

8,6453 gold badges51 silver badges67 bronze badges

1 Comment

daniel__ Over a year ago

you can see on the fly the website: link added

Collectives™ on Stack Overflow

regex javascript- error

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related