Initialising an instance variable with a method from the class

Question

Can I initialize an instance variable in Java, when I initialise it when I declare it, and initialise it with the return value of a method, which I define later in the class.

Something like this:

public class MyClass {

     integers[] myArray = new integers[length()];

     int length() {
     ....

     }
}

length() gives me some number, and I want this number to determine the number of elements in the array. It seems plausible to me, but I get NullPointerException (I don't know whether this mistake initialization is causing the exception, but I don't know what exactly, and because I have never done this initialization before, I am not sure it is correct).

Chris Bunch · Accepted Answer · 2009-02-10 08:14:27Z

3

Seems to work fine for me, with the method static or not static:

public class test
{
    public int[] myarray = new int[this.length()];

    public int length() {
        return 5;
    }

    public static void main(String[] args)
    {
        test foo = new test();
        for (int element : foo.myarray) {
            System.out.println(element);
        }
    }
}

Which produces:

edited Feb 10, 2009 at 8:14

answered Feb 10, 2009 at 7:52

Chris Bunch

90.5k37 gold badges130 silver badges128 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David Grant · Accepted Answer · 2009-02-10 07:59:58Z

2

Before doing this, it might be worth considering if this syntax might be slightly confusing, and that it might be more appropriate to initialize the array in the constructor, or in an initialization block.

private final int[] myArray;

public MyClass() {
    myArray = new int[length()];
}

or

private final int[] myArray;
{
    myArray = new int[length()];
}

edited Feb 10, 2009 at 7:59

answered Feb 10, 2009 at 7:54

David Grant

14.4k3 gold badges62 silver badges65 bronze badges

Comments

Jon Skeet · Accepted Answer · 2009-02-10 08:37:37Z

2

Chances are the problem is somewhere in the length() method. I suspect it refers to a variable which hasn't been appropriately initialized yet. Here's an example of a program which shows that:

public class MyClass {

    int[] myArray = new int[length()];

    // This is only initialized *after* myArray
    String myString = "Hi";

    int length() {
        return myString.length();
    }

    public static void main(String[] args) {
        new MyClass(); // Bang!
    }
}

If this is the problem, I suggest you do the initialization within the constructor instead - that way the ordering is much clearer.

answered Feb 10, 2009 at 8:37

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

1 Comment

Chii Over a year ago

+1. this problem is discussed extensively in effective java java.sun.com/docs/books/effective.

kmkaplan · Accepted Answer · 2009-02-10 07:49:56Z

-3

You have to make the method static:

static int length() { … }

answered Feb 10, 2009 at 7:49

kmkaplan

19k4 gold badges55 silver badges65 bronze badges

Collectives™ on Stack Overflow

Initialising an instance variable with a method from the class

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related