Passing a variable to another function in Javascript

Question

I asked a question a while back about how to get the current variable in a loop and I got the solution :

    for (i in ...)
        {
        ...
          href:"javascript:on_click('+i+');"...}

When i run this, the loop is sending the on_click function the string 'i' instead of the value of i.
Am I using the +variable+ wrong? Can someone explain in more detail what wrapping a variable in + means and why it is not working in my case?

Alexander Gessler · Accepted Answer · 2011-03-23 19:20:54Z

1

Yes, you are - if you start a string with ", you have to end it with " (and vice versa for '), too. The syntax highlighting here at SO demonstrates this quite well too.

 href:"javascript:on_click("+i+");"...}

(What is happening is that ' within a string surrounded by " is treated as regular ' character, it does not start nor end a string literal here).

answered Mar 23, 2011 at 19:20

Alexander Gessler

46.9k7 gold badges86 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Linens Over a year ago

what is it called when i do +i+? I'd like to look up more information on it except I don't know what to search up

Alexander Gessler Over a year ago

What happens is that i is converted to a string and concatenated to the surrounding strings.

Mārtiņš Briedis · Accepted Answer · 2011-03-23 19:21:27Z

0

Try this:

href:"javascript:on_click('" + i + "');"

answered Mar 23, 2011 at 19:21

Mārtiņš Briedis

17.9k5 gold badges59 silver badges78 bronze badges

2 Comments

Linens Over a year ago

YESSS thank you so much! I've been trying to figure this out for so longggg. Could you explain why this works?

Mārtiņš Briedis Over a year ago

Look at this tutorial: quirksmode.org/js/strings.html pretty neat code examples there, that should give you the right idea.

Michael Berkowski · Accepted Answer · 2011-03-23 19:21:50Z

0

Appears that you are missing double quotes to close your string. Javascript doesn't do variable interpolation in a quoted string.

Try:

href:"javascript:on_click('" + i + "');"...}

answered Mar 23, 2011 at 19:21

Michael Berkowski

271k47 gold badges450 silver badges395 bronze badges

Comments

Alnitak · Accepted Answer · 2011-03-23 19:22:22Z

0

You're mixing your quote marks.

It should be:

href: "javascript:on_click('" + i + "');"

Note how the double quotes are necessary at both ends of the invariant parts.

answered Mar 23, 2011 at 19:22

Alnitak

341k72 gold badges420 silver badges503 bronze badges

Collectives™ on Stack Overflow

Passing a variable to another function in Javascript

4 Answers 4

2 Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related