Problem with eval and google closure compiler

Question

I'm using google closure to compress my code but I have a problem with the following line of code:

        eval('this.find(\''+ element_to_append_the_controller+ '\').'+controller_to_load+'(options_for_controller)');

I have to use eval because the method (controller_to_load) I have to execute on the element is variable and depend on the params I get.

My Problem is that I have to pass an object to that method, so I'm doing that as an String representation of the variable name(options_for_controller), but closure will change that name and won't change the variable name in my eval string.

My solutions would be:

getting the variable name dynamic as string
parsing object (with callback functions) to string
disable compressing for these line of codes

But how can I do one of them or is there another solution?

Thanks

Jim Blackler · Accepted Answer · 2011-04-14 12:32:52Z

3

Some programmers use eval because they don't realise instead of writing eval('a.' + b) you can write a[b]

Try this instead of your eval()

this.find(element_to_append_the_controller.toString())[controller_to_load](options_for_controller);

answered Apr 14, 2011 at 12:32

Jim Blackler

23.3k12 gold badges90 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

LeonS Over a year ago

thanks, your right, replaced all evals with this type of dynamic execution, awesome.

Jakub Hampl · Accepted Answer · 2011-04-14 12:32:16Z

0

this.find(element_to_append_the_controller.toString())[controller_to_load](options_for_controller)

AKA don't use eval.

answered Apr 14, 2011 at 12:32

Jakub Hampl

40.7k10 gold badges80 silver badges111 bronze badges

Collectives™ on Stack Overflow

Problem with eval and google closure compiler

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related