Laravel 5.8, Auth::user() is not using User model

Question

I have a function in my User model which is called isAdmin, if "Admin" is set to 1 in the database, it returns true, if not it returns false.

How is this gonna work with Auth::user()?

When I do Auth::user()->isAdmin(), it returns "Property [admin] does not exist on this collection instance."

Thats why I came to the conclusion it may not use the User model?

User model

public function isAdmin() {
   if($this->admin == 1) {
        return true;
     } else {
        return false;
   }
}

public function view () 
    {
        if(Auth::check() && Auth::user()->isAdmin()) {
            $user  = User::all();
            $post  = Post::all();
            $visit = Visits::all();


            return view('admin')->with('post', $post)->with('user', $user)->with('visit', $visit);
        } else {
            return redirect()->to('/');
        }
    }

Sorry, I misstyped in my question. I am already using Auth::user()->isAdmin()) — CunnertA
– CunnertA, Commented Nov 16, 2019 at 10:11
@CunnertA share the code from your isAdmin method, as obviously you are checking for a property to exist on a collection instance. — nakov
– nakov, Commented Nov 16, 2019 at 10:13
Are you sure that the error occurs when you do this? Have you checked dd(Auth::user()->isAdmin()); what is the result? As to me it seems like you are trying somewhere on User::all()->isAdmin(); — nakov
– nakov, Commented Nov 16, 2019 at 10:19

marc_s · Accepted Answer · 2023-12-28 22:05:19Z

1

If I may suggest, for this use case, you can actually make do without an extra function. You could just say auth()->user()->admin, specially if the 'admin' column in the database is boolean type.

Otherwise (even admin column is not boolean type) you can set up a mutator method in the model, like so:

public function getIsAdminAttribute()
{
   return (bool) $this->admin;
}

Then to check you can access it like so: Auth::user()->isAdmin or auth()->user()->isAdmin

And better yet, you might want to read about Gate and Policies to achieve more robust access controlling. https://laravel.com/docs/5.7/authorization

edited Dec 28, 2023 at 22:05

marc_s

760k186 gold badges1.4k silver badges1.5k bronze badges

answered Nov 16, 2019 at 11:19

user3532758

2,2811 gold badge14 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

nakov Over a year ago

Calling is_admin or admin does not make a difference, the OP mentioned that wants to use a method :) + instead of casting it like that the OP can just add protected $casts = ['admin' => 'boolean']; in the model, it will achieve the same.

user3532758 Over a year ago

@nakov good catch. casts array is yet another method for casting and satisfies my main concern (first point) of having an extra method.

nakov Over a year ago

Anyhow 1 = true and 0 = false in PHP, so there is no need for casting unless the user needs to show true or false somewhere :) The error is really obvious, but the user gone away :)

CunnertA Over a year ago

Thank you! I have made it a bool and changed my method. So much cleaner :)

nakov Over a year ago

@CunnertA I really want you to teach me how this solved your problem that you've shared above :D

|

nakov · Accepted Answer · 2019-11-16 10:24:05Z

0

Suggestion, change the code to just this:

public function isAdmin() {
    return $this->admin;
}

This code does exactly the same as you've got above..

Now in your admin.blade.php you are using:

$user->isAdmin();

But in the controller you have:

$user  = User::all();

which returns collection.

You should iterate over it, and check on each user instance if it is an admin:

$users  = User::all();

In the view:

@foreach($users as $user)
 @if($user->isAdmin())
    {{ $user->name }} // some code here..
 @endif
@endforeach

answered Nov 16, 2019 at 10:24

nakov

14.4k14 gold badges74 silver badges129 bronze badges

Comments

Shougat Mahmud Zihan · Accepted Answer · 2019-11-16 10:52:48Z

0

No Need To do anything just check if login then auth()->check() is return true then auth()->user() return the user

public function view () 
    {
        if(auth()->check() && auth()->user()->isAdmin()) {
            $user  = User::all();
            $post  = Post::all();
            $visit = Visits::all();


            return view('admin')->with('post', $post)->with('user', $user)->with('visit', $visit);
        } else {
            return redirect()->to('/');
        }
    }

public function isAdmin()
    {
        return $this->admin;

    }

edited Nov 16, 2019 at 10:52

answered Nov 16, 2019 at 10:32

Shougat Mahmud Zihan

3,7421 gold badge17 silver badges25 bronze badges

5 Comments

CunnertA Over a year ago

tbh I like the way of using a function, its much cleaner for me.

Shougat Mahmud Zihan Over a year ago

i change my answer.please check it

Assad Ullah Ch Over a year ago

There's no need of else block here in the view() method as the return statement is used in the if block and the execution won't go to else if the if statement is true. If the if statement is false, the execution will jump to return redirect()->to('/'); anyways.

Shougat Mahmud Zihan Over a year ago

i just repair his fuction & auth()->user()

Assad Ullah Ch Over a year ago

@albus_severus The else block does not make any sense here. Because the return statement immediately terminates the execution of a function when it is called from within that function

Collectives™ on Stack Overflow

Laravel 5.8, Auth::user() is not using User model

3 Answers 3

7 Comments

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related