Django url regex not matching

Question

I am trying to implement a regex url for these examples:

localhost:8000/curvas?parcela=298

or

localhost:8000/curvas?parcela=7&fk_fecha=234

I tried implementing a similar url regex from django rest framework (documentation) with the following regex path:

re_path(r'curvas(?P<parcela>.+)', views.CurvasFilter.as_view()),

And it works but it is too permisive, for example that url also match the regex:

localhost:8000/curvas?random=298

How can I change the regex to match only the desired url params?

parcela is part of the querystring, not the path, hence you can not capture this with url(..), re_path(..) or path(..). — willeM_ Van Onsem
– willeM_ Van Onsem, Commented Dec 10, 2019 at 15:27

willeM_ Van Onsem · Accepted Answer · 2019-12-10 15:47:23Z

2

The part after the question mark (?) is the querystring [wiki]. It is not part of the path, and thus you can not capture it with path(..) or re_path(..). It would furthermore likely not be a good idea anyway, since often the order of the parameters is random, and thus a regex that matches ?foo=4&bar=2 might have difficulty with ?bar=2&foo=4.

The path is thus:

re_path(r'^curvas/$', views.CurvasFilter.as_view())

You can access the value for parcela with self.request.GET['parcela']. For example:

class CurvasFilter(ListView):
    model = Curvas

    def get_queryset(self):
        return super().get_queryset().filter(
            parcela=self.request.GET['parcela']
        )

edited Dec 10, 2019 at 15:47

answered Dec 10, 2019 at 15:33

willeM_ Van Onsem

482k33 gold badges483 silver badges624 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

David1212k Over a year ago

Thanks, so I will use the following regex: r'^curvas?$' which seems more restrictive, isn't it? (it also requires to the url to have the question mark)

willeM_ Van Onsem Over a year ago

@David1212k: no the question mark is not part of the path either, it should be ^curvas/$ (or ^curvas$, so without the question mark). Note that here the question mark is by the way interpreted as a regular expression quantifier ("zero or one").

Collectives™ on Stack Overflow

Django url regex not matching

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related