Python TypeError when using iteration to find max and min

Question

The error message is：

Traceback (most recent call last):

File "C:/1-Python/2-projects/最值.py", line 18, in elif findMinAndMax([7]) != (7, 7):

File "C:/1-Python/2-projects/最值.py", line 7, in findMinAndMax for i, in L:

TypeError: cannot unpack non-iterable int object

My code

def findMinAndMax(L):
    if L == []:
        return (None, None)
    else:
        max1 = L[0]
        min1 = L[0]
        for i, in L:
            if i >= max1:
                max1 = i
            elif i <= min1:
                min1 = i

        return (min1, max1)


if findMinAndMax([]) != (None, None):
    print('test failed!')
elif findMinAndMax([7]) != (7, 7):
    print('test failed!!')
elif findMinAndMax([7, 1]) != (1, 7):
    print('test failed!!')
elif findMinAndMax([7, 1, 3, 9, 5]) != (1, 9):
    print('test failed!!')
else:
    print('test success!!')

Riccardo Bucco · Accepted Answer · 2019-12-25 09:35:11Z

2

Simply remove the comma in the for loop:

...
for i in L:
    ...

answered Dec 25, 2019 at 9:35

Riccardo Bucco

15.5k4 gold badges29 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Law Shin Over a year ago

I feel so embarrassed that I made such a stupid mistake.Anyway,thanks a lot.^_^

lenik · Accepted Answer · 2019-12-25 09:39:53Z

1

I'd rather use a different code:

def findMinAndMax(L):
    if L == []:
        return (None, None)
    return (min(L), max(L))

Simple, isn't it?

answered Dec 25, 2019 at 9:39

lenik

23.6k4 gold badges38 silver badges44 bronze badges

Collectives™ on Stack Overflow

Python TypeError when using iteration to find max and min

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related