Ternary operator javascript

Question

What is wrong with this code? if I call this function without any arguments, the expected output is "critical" instead "medium" is returned.

let labelBlock = (label="") =>{
        label = label.toLowerCase();
        const txt = label == "high" ? "High" : "medium" ? "Medium" : "Critical";
        return `<span class="${txt.toLowerCase()}">${txt}</span>`;
      }

Nabin Adhikari · Accepted Answer · 2020-02-14 05:34:27Z

3

label is empty at the start. The first condition label == "high" is false and in the second condition you have "medium", which, in Js, is truthy value hence "Medium" is set.

You can change that line to the following to get Critical. See change (label == "medium")

const txt = label == "high" ? "High" : label == "medium" ? "Medium" : "Critical";

answered Feb 14, 2020 at 5:34

Nabin Adhikari

1531 silver badge6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sergey Vishnevskiy · Accepted Answer · 2020-02-14 05:35:17Z

3

You need to replace "medium" with "label == 'medium'".

let labelBlock = (label="") =>{
    label = label.toLowerCase();
    const txt = label == "high" ? "High" : label == "medium" ? "Medium" : "Critical";
    return `<span class="${txt.toLowerCase()}">${txt}</span>`;
}

"medium" expression in the second part is always "true" in your code. So the second ternary operator always returns the first value ("Medium").

answered Feb 14, 2020 at 5:35

Sergey Vishnevskiy

4535 silver badges16 bronze badges

Comments

prasana kannan · Accepted Answer · 2020-02-14 05:37:15Z

1

There is no condition which is evaluated at the second part "medium" ? "Medium" : "Critical";

Hope this works for you

        const txt = label == "high" ? "High" : label == "medium" ? "Medium" : "Critical";

answered Feb 14, 2020 at 5:37

prasana kannan

6846 silver badges14 bronze badges

Comments

Siva Kondapi Venkata · Accepted Answer · 2020-02-14 05:48:17Z

1

Your ternary operation meaning is below. As you can see the problem is you are checking if ("medium").

  var txt;
  if (label == "high") {
    txt = "High";
  } else {
    if ("medium") {
      text = "Medium";
    } else {
      text = "Critical";
    }
  }

answered Feb 14, 2020 at 5:48

Siva Kondapi Venkata

11.1k2 gold badges20 silver badges32 bronze badges

Collectives™ on Stack Overflow

Ternary operator javascript

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related