need help with regex in javascript to replace string pattern

Question

Need help with regex javascript , i tried few but didn't work

i want to replace the the following string which is a url. The values 200, 400 are dynamic in the below string

url=http://www.test.com?debug=true&MAXWIDTH:200+MAXHEIGHT:400

with ,900 , 900 always and the result should be

after regex i want the url string contains the below value

url=http://www.test.com/?debug=true&MAXWIDTH:900+MAXHEIGHT:900

Thanks to all who took time to answer my problem , really appreciate. — kobe
– kobe, Commented May 24, 2011 at 20:23

maerics · Accepted Answer · 2011-05-24 19:53:17Z

3

var replaceMaxWidthAndHeight = function(str, newWidthAndHeight) {
  var i=0;
  return str.replace(/\s*(MAXWIDTH|MAXHEIGHT)\s*:\s*(\d+)\s*/g, function(s, m1) {
    return m1 + ':' + newWidthAndHeight[i++];
  });
};

var s1 = "url=http://www.test.com/?debug=true&MAXWIDTH:200+MAXHEIGHT: 400";
var s2 = replaceMaxWidthAndHeight(s1, [900, 900]);
s2; // => "url=http://www.test.com/?debug=true&MAXWIDTH:900+MAXHEIGHT:900"
s2 = replaceMaxWidthAndHeight(s1, [10, 20]);
s2; // => "url=http://www.test.com/?debug=true&MAXWIDTH:10+MAXHEIGHT:20"

edited May 24, 2011 at 19:53

answered May 24, 2011 at 19:47

maerics

157k47 gold badges277 silver badges299 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

kobe Over a year ago

@maerics , can we do a check for MAXWIDTH AND MAXHEIGHT , it should be followed by those string , i have lot of values in the url , i don't want to replace all of them

kobe Over a year ago

@maerics , can you explain your code , i didn't understand [10,20]

maerics Over a year ago

@kobe: if you ever change from using the value 900 to needing dynamic values for the new width and height, you can pass them in as the second argument. See my updated answer.

gen_Eric Over a year ago

@kobe: [10, 20] is an array of 2 numbers, it can be anything. In your case it would be [900, 900].

morja · Accepted Answer · 2011-05-24 19:54:35Z

2

If you want replace it ignoring the order or if both are there:

str = str.replace(/(MAXWIDTH:|MAXHEIGHT:)\d+/g, '$1900');

answered May 24, 2011 at 19:54

morja

8,5703 gold badges42 silver badges62 bronze badges

Comments

gen_Eric · Accepted Answer · 2011-05-24 19:49:21Z

1

If MAXWIDTH and MAXHEIGHT always appear in the url as MAXWIDTH:200+MAXHEIGHT:400, then this regex will work.

var string = "url=http://www.test.com?debug=true&MAXWIDTH:200+MAXHEIGHT:400";
string.replace(/MAXWIDTH:\d*\+MAXHEIGHT:\d*/, 'MAXWIDTH:900+MAXHEIGHT:900');

answered May 24, 2011 at 19:49

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

1 Comment

kobe Over a year ago

@rockets, thanks very much this is what i want , i want to replace if it finds maxwidth and maxheight..

gen_Eric · Accepted Answer · 2011-05-24 19:58:14Z

1

Replace

(url=http://www.test.com\?debug=true&MAXWIDTH:)\d*(\+MAXHEIGHT:)\d*

with

$1900$2900

(being $1 and $2 the back references to the matching groups

EDIT: Thanks to Rocket

string.replace(/(url=http:\/\/www.test.com\?debug=true&MAXWIDTH:)\d*(\+MAXHEIGH‌T:)\d*/, '$1900$2900')

edited May 24, 2011 at 19:58

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

answered May 24, 2011 at 19:49

Hyperboreus

32.5k9 gold badges50 silver badges88 bronze badges

1 Comment

gen_Eric Over a year ago

Maybe you should put the code in your answer... string.replace(/(url=http:\/\/www.test.com\?debug=true&MAXWIDTH:)\d*(\+MAXHEIGHT:)\d*/, '$1900$2900')

Jonathon · Accepted Answer · 2011-05-24 20:13:32Z

1

Or a more general solution:

function replaceValue(str, label, value) {
    rX = new RegExp("\\s*" + label + "\\s*:\\s*(\\d+)\\s*");
    return(str.replace(rX, label + ":" + value);
}

url = replaceValue(url, "MAXHEIGHT", 900);
url = replaceValue(url, "MAXWIDTH", 900);

answered May 24, 2011 at 20:13

Jonathon

2,6755 gold badges30 silver badges50 bronze badges

Collectives™ on Stack Overflow

need help with regex in javascript to replace string pattern

5 Answers 5

4 Comments

Comments

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

Comments

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related