How can I use php loop inside if else statement

Question

if (isset($_GET['language']) && !empty($_GET['language'] && $_SESSION['language'] !== $_GET['language'])) {
    if ($_GET['language'] === 'en') {
      $_SESSION['language'] = 'en';
    } elseif ($_GET['language'] === 'ar') {
      $_SESSION['language'] = 'ar';
    } elseif ($_GET['language'] === 'de') {
      $_SESSION['language'] = 'de';
    } else {
      $_SESSION['language'] = $default_language;
    }
  }

I would like to loop only elseif statements. Is there away to achieve this?

Looks like you could just set $_SESSION['language'] = $_GET['language'] if $_GET['language'] is set. No need for lots of ifs. If you want to make sure $_GET['language'] can only take certain values use in_array — user8034901
– user8034901, Commented Jun 21, 2021 at 21:49

Tangentially Perpendicular · Accepted Answer · 2021-06-21 21:54:28Z

1

There's no need for a loop here. If your intention is to whitelist the available languages then put a list in an array and use in_array():

$languages = ['ar','de','en'];
if (isset($_GET['language']) && in_array($_GET['language'], $languages)) {
    $_SESSION['language'] = $_GET['language'];
} else {
    $_SESSION['language'] = $default_language;
}

answered Jun 21, 2021 at 21:54

Tangentially Perpendicular

5,4364 gold badges15 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nigel Ren · Accepted Answer · 2021-06-22 03:45:45Z

1

You don't need to do isset and empty as empty will do that for you.

This also checks if the language is in one of the specific ones (using in_array) and if it isn't then it uses the default...

if (!empty($_GET['language']) && $_SESSION['language'] !== $_GET['language']) {
    $_SESSION['language'] = in_array($_GET['language'], ['en', 'ar', 'de'])
            ? $_GET['language'] : $default_language;
}

edited Jun 22, 2021 at 3:45

answered Jun 21, 2021 at 21:54

Nigel Ren

57.3k11 gold badges49 silver badges59 bronze badges

1 Comment

user3783243 Over a year ago

Need to close the empty sooner. !empty($_GET['language'])

Collectives™ on Stack Overflow

How can I use php loop inside if else statement

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related