In an Angular.js controller's scope function code doesn't run below a $timeout statement inside

Question

I have a button for which I have set ng-click="refresh()". The console logs before the timeout function logs correctly but the console log inside the $timeout block and after the block doesn't seem to log. If I remove the $timeout block every console log works. I even checked with $interval instead of $timeout but same behaviour.

I wanted to do something like this here

I'm using Angular.js 1.4.0

This is my implementation inside the controller

      $scope.refreshing ={state: false};
      $scope.refresh = function(){
        console.log($scope);
        $scope.refreshing.state = true;
        $scope.search(); //sends an http request and loads results.
        console.log('this logs');
        // $scope.refreshing.state = false;
        $timeout(function(){
           console.log('this doesnt log')
           $scope.refreshing.state = false;
         },2000);
        console.log('this doesnt log')

      }

Sounds like it's crashing. Any errors in the console? Maybe $timeout isn't defined. — Jacob Stamm
– Jacob Stamm, Commented Feb 8, 2022 at 14:04
Yes. You can find all the built-in AngularJS services listed here. Can you edit your question to include the controller function definition, as well as the code where you're registering the controller in your angular.module()? And to be clear, you're saying there are no errors in your JS console? — Jacob Stamm
– Jacob Stamm, Commented Feb 8, 2022 at 14:11
You're not answering my question about the JS console errors — Jacob Stamm
– Jacob Stamm, Commented Feb 8, 2022 at 14:21
I need to see the definition of your controller function to make sure you're using the dependency injection properly — Jacob Stamm
– Jacob Stamm, Commented Feb 8, 2022 at 14:24
or great now it makes sense. i havent added the $timeout in the dependancy array — cmgchess
– cmgchess, Commented Feb 8, 2022 at 14:26

Jacob Stamm · Accepted Answer · 2022-02-08 14:41:49Z

1

You'll want to make sure your dependency injection is wired up properly. For example:

angular
    .module("MyApp")
    .controller("MyController", ["$scope", "$timeout", MyController]);

function MyController($scope, $timeout) {
    // controller code
}

See John Papa's AngularJS style guide for some best practices relating to controllers.

answered Feb 8, 2022 at 14:41

Jacob Stamm

1,9083 gold badges36 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

In an Angular.js controller's scope function code doesn't run below a $timeout statement inside

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related